| To: | Shane McDonald <mcdonald.shane@gmail.com> |
|---|---|
| Subject: | Re: [PATCH] fix build failures on msp_irq_slp.c |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Mon, 13 Jul 2009 12:53:06 +0100 |
| Cc: | Florian Fainelli <florian@openwrt.org>, linux-mips@linux-mips.org |
| In-reply-to: | <b2b2f2320907120934x6d6e4059ma318fe6236e45b19@mail.gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200904271659.48357.florian@openwrt.org> <200904291512.19297.florian@openwrt.org> <b2b2f2320904290718pe9a28efy9a8af432887778cb@mail.gmail.com> <200906280701.32649.florian@openwrt.org> <b2b2f2320907110351o1473fc79xa3926b8af4ffc35@mail.gmail.com> <b2b2f2320907120934x6d6e4059ma318fe6236e45b19@mail.gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Sun, Jul 12, 2009 at 10:34:45AM -0600, Shane McDonald wrote: > > My apologies for the delay in replying to your latest prompt -- I've been > > on vacation with little internet access. > > > > Your patch looks correct to me, but as Ralf says, the existing code is a > > little suspect. In my poking around, I've come across three different > > versions of this file: the in-tree version, the latest out-of-tree patch > > from PMC-Sierra, and an unreleased version from a colleague. None appear to > > be quite correct. I think I've got enough info, though, to come up with a > > good version. > > > > I'll cook something up this weekend and get it posted. > > > OK, I've done my cooking, and the cleanup patch will follow in a separate > email. It expects Florian's patch to have been applied. > > Florian's patch is correct, so I'll add my: > > Acked-by: Shane McDonald <mcdonald.shane@gmail.com> Okay, applied. Thanks! Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] MIPS: fix loading of modules with unresolved weak symbols, Ralf Baechle |
|---|---|
| Next by Date: | Re: [PATCH] define MIPS34K_MISSED_ITLB_WAR for other PMC-Sierra SoC, Ralf Baechle |
| Previous by Thread: | Re: [PATCH] fix build failures on msp_irq_slp.c, Florian Fainelli |
| Next by Thread: | [PATCH] Simplify and correct interrupt handling for MSP4200, Shane McDonald |
| Indexes: | [Date] [Thread] [Top] [All Lists] |