linux-mips
[Top] [All Lists]

Re: [PATCH] fix build failures on msp_irq_slp.c

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] fix build failures on msp_irq_slp.c
From: Shane McDonald <mcdonald.shane@gmail.com>
Date: Sun, 12 Jul 2009 10:34:45 -0600
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=8LCjEEDuiRR3SOHPWe7k+AZf4pMa8jXWcPSxMehx2tQ=; b=PPHcA7GJWfLMm7AugFb8U5q5VscucAv5FZlvV06rqygPMSjmMqWylLb9wuVUmLBE+x RcnN86zIBtdUolD/P2S+MlwAwr9ShxNPHtYf9x5OQrlPxoQZ1UargITqMyPzw/WThT+4 BJYpgMxZxTvodr1rCJvj1neQW7gWhgccgoitk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=d/RESkxJgCx4vFiULTMtW4FWIs1Bv2t2wmWaqGSUwcNjcFcr8qcu+ZB3BBzPzka0OB jjEYH8m/K3SMSr32RfW1/RwZHqPY5F2vnSiGIUgXI7vPdfGuXJHr3eeTgrgkz1mqXNIc yqq5rDDbi5SY/cYYzYHsC9bLwztX0gG3AWdMk=
In-reply-to: <b2b2f2320907110351o1473fc79xa3926b8af4ffc35@mail.gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200904271659.48357.florian@openwrt.org> <200904291512.19297.florian@openwrt.org> <b2b2f2320904290718pe9a28efy9a8af432887778cb@mail.gmail.com> <200906280701.32649.florian@openwrt.org> <b2b2f2320907110351o1473fc79xa3926b8af4ffc35@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Sat, Jul 11, 2009 at 4:51 AM, Shane McDonald <mcdonald.shane@gmail.com> wrote:
Hi Florian:

  My apologies for the delay in replying to your latest prompt -- I've been on vacation with little internet access.

  Your patch looks correct to me, but as Ralf says, the existing code is a little suspect.  In my poking around, I've come across three different versions of this file: the in-tree version, the latest out-of-tree patch from PMC-Sierra, and an unreleased version from a colleague.  None appear to be quite correct.  I think I've got enough info, though, to come up with a good version.

  I'll cook something up this weekend and get it posted.

OK, I've done my cooking, and the cleanup patch will follow in a separate email.  It expects Florian's patch to have been applied.

Florian's patch is correct, so I'll add my:

Acked-by: Shane McDonald <mcdonald.shane@gmail.com>

Shane

<Prev in Thread] Current Thread [Next in Thread>