linux-mips
[Top] [All Lists]

Re: [PATCH] fix build failures on msp_irq_slp.c

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] fix build failures on msp_irq_slp.c
From: Shane McDonald <mcdonald.shane@gmail.com>
Date: Sat, 11 Jul 2009 04:51:16 -0600
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=NyLR2adUB/qCEmKm+5KYYEzR3yCNSy5U87+iS4CaLfQ=; b=eZP9zHFcgzYACYF07YTQsLdPODeWC4vXS2sU5QF7P4LZELIbhdsaHQZYYWErNTbDzd fRjOnDrfyVWkULG41/j3dideIUibLu6VeKdpvw6Tb0ui/Fdr2rKtiAAfIC7qhWoR2ZxG 0hulP6MCuwKafbh7k7Y0LcIwfBJCENHDeoVZ0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=TGS/NWJnPJt9eiT4VVwKBbLkhx1ndnUHEaa13HENISGm5o8RX1RgkYeK+qYy4QBrKF zlkVPxVSEtSRfB8s1NWxqHcQHeaALJiGRXBmRkqJwV7c+wX1BBCL4x7TGeSVqRN8XWAe 3HreH4WguOPb1r46FXK1e84nRzTnofIhm4/zU=
In-reply-to: <200906280701.32649.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200904271659.48357.florian@openwrt.org> <200904291512.19297.florian@openwrt.org> <b2b2f2320904290718pe9a28efy9a8af432887778cb@mail.gmail.com> <200906280701.32649.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
Hi Florian:

  My apologies for the delay in replying to your latest prompt -- I've been on vacation with little internet access.

  Your patch looks correct to me, but as Ralf says, the existing code is a little suspect.  In my poking around, I've come across three different versions of this file: the in-tree version, the latest out-of-tree patch from PMC-Sierra, and an unreleased version from a colleague.  None appear to be quite correct.  I think I've got enough info, though, to come up with a good version.

  I'll cook something up this weekend and get it posted.

Shane

On Sat, Jun 27, 2009 at 11:01 PM, Florian Fainelli <florian@openwrt.org> wrote:
Hi Shane,

Le Wednesday 29 April 2009 16:18:11 Shane McDonald, vous avez écrit :
> Hello:
>
> On Wed, Apr 29, 2009 at 7:12 AM, Florian Fainelli
<florian@openwrt.org>wrote:
> > Hi Ralf, Shane,
> >
> > Le Wednesday 29 April 2009 13:58:59 Ralf Baechle, vous avez écrit :
> > > The whole irq chip thing in this file is looking suspect as it treats
> > > acknowledging and mask an interrupt as the same thing.  Sure that is
> > > the right thing?
> >
> > That is a quick and dirty fix which compiles, I assumed that the function
> > meant to be called is mask_msp_slp_irq, Shane probably knows more about
> > how this should be fixed.
>
> It's been quite a while since I messed around with the 4200.  I'll do some
> digging and ask some questions of guys who probably know better.

Any updates on that patch ? Thank you very much.
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

<Prev in Thread] Current Thread [Next in Thread>