Re: [PATCH] fix build failures on msp_irq_slp.c

[Shane McDonald <mcdonald.shane@gmail.com>]

Hi Florian:

  My apologies for the delay in replying to your latest prompt -- I've been on vacation with little internet access.

  Your patch looks correct to me, but as Ralf says, the existing code is a little suspect.  In my poking around, I've come across three different versions of this file: the in-tree version, the latest out-of-tree patch from PMC-Sierra, and an unreleased version from a colleague.  None appear to be quite correct.  I think I've got enough info, though, to come up with a good version.

  I'll cook something up this weekend and get it posted.

Shane

On Sat, Jun 27, 2009 at 11:01 PM, Florian Fainelli <florian@openwrt.org> wrote:

Hi Shane,

Le Wednesday 29 April 2009 16:18:11 Shane McDonald, vous avez écrit :

> Hello:
>
> On Wed, Apr 29, 2009 at 7:12 AM, Florian Fainelli
<florian@openwrt.org>wrote:
> > Hi Ralf, Shane,
> >
> > Le Wednesday 29 April 2009 13:58:59 Ralf Baechle, vous avez écrit :
> > > The whole irq chip thing in this file is looking suspect as it treats
> > > acknowledging and mask an interrupt as the same thing.  Sure that is
> > > the right thing?
> >
> > That is a quick and dirty fix which compiles, I assumed that the function
> > meant to be called is mask_msp_slp_irq, Shane probably knows more about
> > how this should be fixed.
>
> It's been quite a while since I messed around with the 4200.  I'll do some
> digging and ask some questions of guys who probably know better.

Any updates on that patch ? Thank you very much.

--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------