| To: | Linus Torvalds <torvalds@linux-foundation.org> |
|---|---|
| Subject: | Re: [BUG] drivers/video/sis: deadlock introduced by "fbdev: add mutex for fb_mmap locking" |
| From: | Krzysztof Helt <krzysztof.h1@poczta.fm> |
| Date: | Sun, 5 Jul 2009 17:05:47 +0200 |
| Cc: | Wu Zhangjin <wuzhangjin@gmail.com>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Krzysztof Helt <krzysztof.h1@wp.pl>, Peter Zijlstra <a.p.zijlstra@chello.nl>, "Rafael J. Wysocki" <rjw@sisk.pl>, Andrew Morton <akpm@linux-foundation.org>, Ralf Baechle <ralf@linux-mips.org>, 晏华 <yanh@lemote.com>, zhangfx <zhangfx@lemote.com> |
| In-reply-to: | <alpine.LFD.2.01.0907050715490.3210@localhost.localdomain> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1246785112.14240.34.camel@falcon> <alpine.LFD.2.01.0907050715490.3210@localhost.localdomain> |
| Sender: | linux-mips-bounce@linux-mips.org |
On Sun, 5 Jul 2009 07:19:33 -0700 (PDT) Linus Torvalds <torvalds@linux-foundation.org> wrote: > > > On Sun, 5 Jul 2009, Wu Zhangjin wrote: > > > > then it works! so, I guess there is a deadlock introduced by the above > > commit. > > Hmm. Perhaps more likely, the 'mm_lock' mutex hasn't even been initialized > yet. We appear to have had that problem with matroxfb and sm501fb, and it > may be more common than that. See commit f50bf2b2. > > That said, I do agree that the mm_lock seems to be causing more problems > than it actually fixes, and maybe we should revert it. Krzysztof? > I vote for fixing these drivers after my change. I will send a patch for the sis driver soon. I am building new kernel now. Regards, Krzysztof ---------------------------------------------------------------------- Rozwiaz krzyzowke i wygraj nagrody! Sprawdz >> http://link.interia.pl/f2232 |
| Previous by Date: | Re: [BUG] drivers/video/sis: deadlock introduced by "fbdev: add mutex for fb_mmap locking", Paul Mundt |
|---|---|
| Next by Date: | Re: [BUG] drivers/video/sis: deadlock introduced by "fbdev: add mutex for fb_mmap locking", Linus Torvalds |
| Previous by Thread: | Re: [BUG] drivers/video/sis: deadlock introduced by "fbdev: add mutex for fb_mmap locking", Krzysztof Helt |
| Next by Thread: | [PATCH] kernel: fix MIPS compile for !CONFIG_SMP, Alexander Clouter |
| Indexes: | [Date] [Thread] [Top] [All Lists] |