| To: | Wu Zhangjin <wuzhangjin@gmail.com> |
|---|---|
| Subject: | Re: [PATCH] [MIPS] Hibernation: only save pages in system ram |
| From: | Pavel Machek <pavel@ucw.cz> |
| Date: | Thu, 2 Jul 2009 23:45:03 +0200 |
| Cc: | LKML <linux-kernel@vger.kernel.org>, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Wu Zhangjin <wuzj@lemote.com> |
| In-reply-to: | <1246373570-21090-1-git-send-email-wuzhangjin@gmail.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1246373570-21090-1-git-send-email-wuzhangjin@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
> arch/mips/include/asm/page.h: > > ... > #ifdef CONFIG_FLATMEM > > #define pfn_valid(pfn) ((pfn) >= ARCH_PFN_OFFSET && (pfn) < > max_mapnr) > > #elif defined(CONFIG_SPARSEMEM) > > /* pfn_valid is defined in linux/mmzone.h */ > ... > > we can rewrite pfn_valid(pfn) to fix this problem, but I really do not > want to touch such a widely-used macro, so, I used another solution: Well, fixing pfn_valid() is the right way to go. It makes mips behave like other architectures. Please do that. > Signed-off-by: Wu Zhangjin <wuzj@lemote.com> NAK. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Bug #13663] suspend to ram regression (IDE related), Bartlomiej Zolnierkiewicz |
|---|---|
| Next by Date: | RE: [PATCH 15/15] Do not rely on the initial state of TC/VPE bindings when doing cross VPE writes, Gandham, Raghu |
| Previous by Thread: | [PATCH] update Yoichi's e-mail addresses, Yoichi Yuasa |
| Next by Thread: | Re: [PATCH] [MIPS] Hibernation: only save pages in system ram, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |