| To: | "Maciej W. Rozycki" <macro@linux-mips.org> |
|---|---|
| Subject: | Re: [PATCH] [MIPS] Malta: Remove unneeded function protos from malta-reset.c |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Wed, 1 Jul 2009 07:31:16 +0100 |
| Cc: | Dmitri Vorobiev <dmitri.vorobiev@movial.com>, linux-mips@linux-mips.org |
| In-reply-to: | <alpine.LFD.2.00.0907010108380.23134@eddie.linux-mips.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1246035565-24015-1-git-send-email-dmitri.vorobiev@movial.com> <20090628181702.GB20084@linux-mips.org> <alpine.LFD.2.00.0907010108380.23134@eddie.linux-mips.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Wed, Jul 01, 2009 at 01:17:22AM +0100, Maciej W. Rozycki wrote:
> > There should be a tax on useless prototypes and also excessive parentheses
> > ;-)
>
> And insufficient parentheses causing the average reader to refer to the
> language spec for the operator priority list. ;)
Code written to require intimate knowledge of all operator priorities is
probably as bad as overuse. Here a few examples:
return (1);
#define FOO (42)
a = (b + c);
a = (b + c) + d;
a = (b * c) + (d * e);
if ((a > b) && (a < c))
Ralf
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] MIPS: Define __arch_swab64 for all mips r2 cpus (v2)., Maciej W. Rozycki |
|---|---|
| Next by Date: | Re: [PATCH] linux-2.4: br2684: fix double freeing skb, Willy Tarreau |
| Previous by Thread: | Re: [PATCH] [MIPS] Malta: Remove unneeded function protos from malta-reset.c, Maciej W. Rozycki |
| Next by Thread: | Re: [PATCH] [MIPS] Malta: Remove unneeded function protos from malta-reset.c, Maciej W. Rozycki |
| Indexes: | [Date] [Thread] [Top] [All Lists] |