linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Define __arch_swab64 for all mips r2 cpus (v2).

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH] MIPS: Define __arch_swab64 for all mips r2 cpus (v2).
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 29 Jun 2009 20:34:54 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <1246294455-26866-1-git-send-email-ddaney@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1246294455-26866-1-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jun 29, 2009 at 09:54:15AM -0700, David Daney wrote:

> Some CPUs implement mipsr2, but because they are a super-set of
> mips64r2 do not define CONFIG_CPU_MIPS64_R2.  Cavium OCTEON falls into
> this category.  We would still like to use the optimized
> implementation, so since we have already checked for
> CONFIG_CPU_MIPSR2, checking for CONFIG_64BIT instead of
> CONFIG_CPU_MIPS64_R2 is sufficient.
> 
> Change from v1: Add comments about why the change is safe.

Thanks, applied.  Though this sort of patch make me thing that maybe we
rather should have treated the cnMIPS cores differently.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>