linux-mips
[Top] [All Lists]

[PATCH] linux-2.4: vlan: Slab memleak fix

To: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: [PATCH] linux-2.4: vlan: Slab memleak fix
From: Frank Seidel <Frank.Seidel@sphairon.com>
Date: Mon, 29 Jun 2009 14:21:41 +0200
Cc: "Seidel, Frank" <Frank.Seidel@sphairon.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090318)
Author: Arne Redlich <readlicha@sphairon.com>

Fix slab memleak on wan service restart

Signed-off-by: Arne Redlich <redlicha@sphairon.com>
Signed-off-by: Frank Seidel <Frank.Seidel@sphairon.com>
---
 net/8021q/vlan_dev.c |   22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -548,6 +548,22 @@ int vlan_dev_set_ingress_priority(char *
        return -EINVAL;
 }
 
+/* Remove all egress_priority_map hash table entries. --redlicha */
+static void vlan_dev_destroy_egress_priority_map(struct net_device *dev)
+{
+       struct vlan_dev_info *info = VLAN_DEV_INFO(dev);
+       struct vlan_priority_tci_mapping *m;
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(info->egress_priority_map); i++) {
+               while ((m = info->egress_priority_map[i])) {
+                       info->egress_priority_map[i] =
+                               info->egress_priority_map[i]->next;
+                       kfree(m);
+               }
+       }
+}
+
 int vlan_dev_set_egress_priority(char *dev_name, __u32 skb_prio, short 
vlan_prio)
 {
        struct net_device *dev = dev_get_by_name(dev_name);
@@ -826,7 +842,11 @@ void vlan_dev_destruct(struct net_device
                if (dev->priv) {
                        if (VLAN_DEV_INFO(dev)->dent)
                                BUG();
-
+                       /*
+                        * Don't leak the hash table entries in
+                        * VLAN_DEV_INFO(dev)->egress_priority_map! --redlicha
+                        */
+                       vlan_dev_destroy_egress_priority_map(dev);
                        kfree(dev->priv);
                        dev->priv = NULL;
                }


<Prev in Thread] Current Thread [Next in Thread>