linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] octeon: only build flash_setup code when CONFIG_MTD is s

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 2/2] octeon: only build flash_setup code when CONFIG_MTD is set
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 22 Jun 2009 15:40:42 +0100
Cc: linux-mips@linux-mips.org, David Daney <ddaney@caviumnetworks.com>
In-reply-to: <200906221116.21621.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200906221116.21621.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Jun 22, 2009 at 11:16:21AM +0200, Florian Fainelli wrote:

> This patch makes the flash_setup code be compiled only when
> CONFIG_MTD is set, it does make sense to register a physmap
> platform driver without the MTD subsystem being enabled.

No.  A user might build the MTD subsystem as a module and then insert it
into a running system so the idea is to always register the devices.  This
also keeps the information in /proc/iomem rsp. /proc/iostat and sysfs
more useful.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>