linux-mips
[Top] [All Lists]

RE: [PATCH 4/5] Move gcmp_probe to before the SMP ops

To: "'Ralf Baechle'" <ralf@linux-mips.org>
Subject: RE: [PATCH 4/5] Move gcmp_probe to before the SMP ops
From: "Tim Anderson" <tanderson@mvista.com>
Date: Wed, 17 Jun 2009 08:40:38 -0700
Cc: <linux-mips@linux-mips.org>
In-reply-to: <20090617082118.GC13467@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
Thread-index: AcnvJLt6fi/1ICoOQFWriPlIff8wIgAPKQjw
 

> -----Original Message-----
> From: Ralf Baechle [mailto:ralf@linux-mips.org] 
> Sent: Wednesday, June 17, 2009 1:21 AM
> To: Tim Anderson
> Cc: linux-mips@linux-mips.org
> Subject: Re: [PATCH 4/5] Move gcmp_probe to before the SMP ops
> 
> On Tue, Jun 16, 2009 at 05:00:35PM -0700, Tim Anderson wrote:
> 
> > @@ -358,10 +361,16 @@ void __init prom_init(void)
> >  #ifdef CONFIG_SERIAL_8250_CONSOLE
> >     console_config();
> >  #endif
> > +   /* Early detection of CMP support */
> > +   result = gcmp_probe(GCMP_BASE_ADDR, GCMP_ADDRSPACE_SZ);
> > +
> >  #ifdef CONFIG_MIPS_CMP
> > -   register_smp_ops(&cmp_smp_ops);
> > +   if (result) register_smp_ops(&cmp_smp_ops);
> 
> Keep the register_smp_ops on a separate line.
> 
> >  #endif
> >  #ifdef CONFIG_MIPS_MT_SMP
> > +#ifdef CONFIG_MIPS_CMP
> > +   if (!result)
> > +#endif
> >     register_smp_ops(&vsmp_smp_ops);
> 
> Suggested rewrite for readability and to silence checkpatch:
> 
> #ifdef CONFIG_MIPS_CMP
>       if (!result)
>               register_smp_ops(&vsmp_smp_ops);
> #else
>       register_smp_ops(&vsmp_smp_ops);
> #endif
> 
>   Ralf

Yes that may be better to understand.

I will re-submit.


<Prev in Thread] Current Thread [Next in Thread>