linux-mips
[Top] [All Lists]

Re: [PATCH 4/5] Move gcmp_probe to before the SMP ops

To: Tim Anderson <tanderson@mvista.com>
Subject: Re: [PATCH 4/5] Move gcmp_probe to before the SMP ops
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 17 Jun 2009 09:21:18 +0100
Cc: linux-mips@linux-mips.org
In-reply-to: <20090617000035.GG6346@shomer.az.mvista.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20090617000035.GG6346@shomer.az.mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Jun 16, 2009 at 05:00:35PM -0700, Tim Anderson wrote:

> @@ -358,10 +361,16 @@ void __init prom_init(void)
>  #ifdef CONFIG_SERIAL_8250_CONSOLE
>       console_config();
>  #endif
> +     /* Early detection of CMP support */
> +     result = gcmp_probe(GCMP_BASE_ADDR, GCMP_ADDRSPACE_SZ);
> +
>  #ifdef CONFIG_MIPS_CMP
> -     register_smp_ops(&cmp_smp_ops);
> +     if (result) register_smp_ops(&cmp_smp_ops);

Keep the register_smp_ops on a separate line.

>  #endif
>  #ifdef CONFIG_MIPS_MT_SMP
> +#ifdef CONFIG_MIPS_CMP
> +     if (!result)
> +#endif
>       register_smp_ops(&vsmp_smp_ops);

Suggested rewrite for readability and to silence checkpatch:

#ifdef CONFIG_MIPS_CMP
        if (!result)
                register_smp_ops(&vsmp_smp_ops);
#else
        register_smp_ops(&vsmp_smp_ops);
#endif

  Ralf

<Prev in Thread] Current Thread [Next in Thread>