linux-mips
[Top] [All Lists]

Re: [PATCH-v2] Hibernation Support in mips system

To: wuzhangjin@gmail.com
Subject: Re: [PATCH-v2] Hibernation Support in mips system
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 16 Jun 2009 12:01:53 +0100
Cc: linux-mips@linux-mips.org, Arnaud Patard <apatard@mandriva.com>, Atsushi Nemoto <anemo@mba.ocn.ne.jp>, Yan Hua <yanh@lemote.com>, Zhang Fuxin <zhangfx@lemote.com>, Pavel Machek <pavel@ucw.cz>, Wu Zhangjin <wuzj@lemote.com>, Hu Hongbing <huhb@lemote.com>
In-reply-to: <9c9bc070f3c272c41254304537e9dec398245b94.1244118419.git.wuzj@lemote.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <9c9bc070f3c272c41254304537e9dec398245b94.1244118419.git.wuzj@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jun 04, 2009 at 08:27:10PM +0800, wuzhangjin@gmail.com wrote:

> This is pulled from the to-mips branch of
> http://dev.lemote.com/code/linux_loongson, the original author is Hu
> Hongbing from www.lemote.com
> 
> according to the feedback from Atsushi Nemoto, Arnaud Patard, Yanhua,
> Pavel Machek and Ralf Baechle. I removed the a0-a7,v1 registers
> saving/restoring, added cache/tlb flushing and fpu,dsp registers
> saving/restoring, and also tuned some coding style problem with the
> support of scripts/checkpatch.pl and added GPL notice.

SMP support requires CPU hotplugging which MIPS currently doesn't support.
As implemented in this patch cache and tlb flushing will also be
invoked with interrupts disabled so smp_call_function() will blow up in
charming ways.  My request to move the cache and tlb flushing code was
ignored but since this matter will need revisiting anyway and hibernation
is a very useful feature I decieded to take the patch but limit hibernation
to !SMP.

Thanks folks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>