linux-mips
[Top] [All Lists]

Re: [PATCH v3] filter local function prefixed by $L

To: Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v3] filter local function prefixed by $L
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Tue, 16 Jun 2009 02:48:30 +0800
Cc: David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Wang Liming <liming.wang@windriver.com>, Ralf Baechle <ralf@linux-mips.org>, Thomas Gleixner <tglx@linutronix.de>, Nicholas Mc Guire <der.herr@hofr.at>, Ingo Molnar <mingo@elte.hu>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=n57I1P28JstXL0lgUO+A26FkDlRuyESv5LJou/akgao=; b=qewarFwabRDwpJpsF6zrbGTn8C+dgSZg//SZihbSp14cXyMXFdBbqunvfj8ZLPsPWS O0q0jSYbyXrdMSLVFsoSnZEpvaEaXhA9NYwhK1J+AdRIqyhNoPr1uMfG/kxlwa4dIWLd BbEu1ZaoJON/UVRm+Mmgi7Fnpqd3eC1/LHbj4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=Ocs0P99hOJ/Nlw/VsiP0393HVJ0+OBkqpYqGRVs2UfV6lPBWTRz+9rADqxjSVGyoDp vlysmuKEiEIIuk7DWqssU2zXoH9tLCY0dpOpxgy1vNUrxJxxV7kxezcqq3BuU9n7v/dz Rg9Jh8W7rH5JvLYm9+SMdeyN3CeH+ureuBFlQ=
In-reply-to: <alpine.DEB.2.00.0906151214160.30161@gandalf.stny.rr.com>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1244994151.git.wuzj@lemote.com> <d0983eb71d7517d0e536352f3288e995abbb0e07.1244994151.git.wuzj@lemote.com> <4A366FF7.2010206@caviumnetworks.com> <alpine.DEB.2.00.0906151214160.30161@gandalf.stny.rr.com>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Mon, 2009-06-15 at 12:30 -0400, Steven Rostedt wrote:
> On Mon, 15 Jun 2009, David Daney wrote:
> 
> > Wu Zhangjin wrote:
> > > From: Wu Zhangjin <wuzj@lemote.com>
> > > 
> > > this patch fixed the warning as following:
> > > 
> > > mipsel-linux-gnu-objcopy: 'fs/proc/.tmp_gl_devices.o': No such file
> > > mipsel-linux-gnu-ld: fs/proc/.tmp_gl_devices.o: No such file: No such
> > > file or directory
> > > rm: cannot remove `fs/proc/.tmp_gl_devices.o': No such file or directory
> > > rm: cannot remove `fs/proc/.tmp_mx_devices.o': No such file or directory
> > > 
> > > the real reason of above warning is that the $Lxx local functions will
> > > be treated as global symbols, so, should be filtered.
> > > 
> > > Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
> > > ---
> > >  scripts/recordmcount.pl |    4 ++++
> > >  1 files changed, 4 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> > > index 533d3bf..542cb04 100755
> > > --- a/scripts/recordmcount.pl
> > > +++ b/scripts/recordmcount.pl
> > > @@ -343,6 +343,10 @@ sub update_funcs
> > >   if (!$use_locals) {
> > >       return;
> > >   }
> > > + # filter $LXXX tags
> > > + if ("$ref_func" =~ m/\$L/) {
> > > +         return;
> > > + }
> > 
> > Certainly this is true for mips.  I doubt it is for all architectures targed
> > by Linux.
> 

have tried to use function_regex instead, but for I'm poor in playing
with regular expression of perl. at last, i use something easier like
above. and I _guess_ this problem maybe exist in some other platforms,
so just put it there.

> Yes, that should probably go into a mips only change. Unless you can 
> reproduce it on all other archs, or at least x86.
> 
> You could also do this in the function_regex variable.
> 
>  "^([0-9a-fA-F]+)\\s+<(.|[^\$]L.*?|\$[^L].*?|[^\$][^L].*?)>:"
> 

works well, and this seems mips64-specific, so, I moved this specific
function_regex to "if ($bits == 64) { ... }".

> There may even be a better way, but I'm not in the mood to look it up ;-)

seems not that easy to understand :-)

-- Wu Zhangjin


<Prev in Thread] Current Thread [Next in Thread>