linux-mips
[Top] [All Lists]

Re: [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_s

To: Wu Zhangjin <wuzhangjin@gmail.com>
Subject: Re: [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h
From: Frederic Weisbecker <fweisbec@gmail.com>
Date: Sun, 14 Jun 2009 14:34:52 +0200
Cc: linux-kernel@vger.kernel.org, Linux-MIPS <linux-mips@linux-mips.org>, Steven Rostedt <rostedt@goodmis.org>, Ralf Baechle <ralf@linux-mips.org>, Pekka Enberg <penberg@cs.helsinki.fi>, Wu Zhangjin <wuzj@lemote.com>, Ingo Molnar <mingo@elte.hu>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=C8XidLopmqtuoN+vScvDWMSL/uAVHYnl28UvTLlxZWI=; b=g5/z9RAzxzcAPdwl0EoO6c84r3+dq2brgdTluXoA7t1Fi8gMwMh2rKjP/SHwJ6uOjk 7iSZhOUpXxeBJQsjL+llSMdqAqSObzA0KMZGEOmzifIDAwL7CHcwvT4FO7Q4dMYCJoRz h45Yrdr8nDX3SvDatMZAhA1brm++xol1dyDRY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=Dt3HnN1JKUlRGAHSny6jra3co/CudyCevfqNsqTpXaQ5jI3/L3+9usWwLjhmj1KmOG ILhBWAONwR2fCKAvGiIkbTZpEvD+ZYKit2kOjYi7480cCfY88R7Kna8gMu8fdLpOmcnK pmXD8uX9enJV11ye0EPwlCaFTbZyGRi22L+6A=
In-reply-to: <1244962350-28702-1-git-send-email-wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1244962350-28702-1-git-send-email-wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Jun 14, 2009 at 02:52:30PM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzj@lemote.com>
> 
> when compiling linux-mips with kmemtrace enabled, there will be an
> error:
> 
> include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
>                               a function)
> 
> I checked the source code and found trace_seq.h used PAGE_SIZE but not
> included the relative header file, so, fix it via adding the header file
> <asm/page.h>
> 
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> Signed-off-by: Wu Zhangjin <wuzj@lemote.com>


Acked-by: Frederic Weisbecker <fweisbec@gmail.com>


> ---
>  include/linux/trace_seq.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
> index c68bccb..c134dd1 100644
> --- a/include/linux/trace_seq.h
> +++ b/include/linux/trace_seq.h
> @@ -3,6 +3,8 @@
>  
>  #include <linux/fs.h>
>  
> +#include <asm/page.h>
> +
>  /*
>   * Trace sequences are used to allow a function to call several other 
> functions
>   * to create a string of data to use (up to a max of PAGE_SIZE.
> -- 
> 1.6.0.4
> 


<Prev in Thread] Current Thread [Next in Thread>