linux-mips
[Top] [All Lists]

Re: [PATCH] Make it compile.

To: Alexey Zaytsev <zaytsev@altell.ru>
Subject: Re: [PATCH] Make it compile.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 12 Jun 2009 13:33:41 +0100
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-mips@linux-mips.org
In-reply-to: <4A30EE9B.30206@altell.ru>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20090610140002.17913.33485.stgit@bzz.altell.local> <4A2FBFE5.2090205@ru.mvista.com> <4A30EE9B.30206@altell.ru>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jun 11, 2009 at 03:46:35PM +0400, Alexey Zaytsev wrote:

>>> diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
>>> index f69c6b5..222bed0 100644
>>> --- a/arch/mips/lib/delay.c
>>> +++ b/arch/mips/lib/delay.c
>>> @@ -51,6 +51,6 @@ void __ndelay(unsigned long ns)
>>>  {
>>>      unsigned int lpj = current_cpu_data.udelay_val;
>>>  -    __delay((us * 0x00000005 * HZ * lpj) >> 32);
>>> +    __delay((ns * 0x00000005 * HZ * lpj) >> 32);
>>
>>    This (and more) is already fixed by the patch posted by Atsushi  
>> Nemoto.
> Thanks for noticing. I should really start reading the ml before
> sending any more patches. ;)
>
>
> -- 
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.

Obviously it doesn't scan for old patches ;-)

(and why would we believe such a statement sent over an insecure medium
anyway)

There is one open nit in the udelay rewrite which I'm about to fix now.

Cheers,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>