linux-mips
[Top] [All Lists]

Re: [loongson-dev] Re: [loongson-PATCH-v3 17/25] add a machtype kernel c

To: Zhang Le <r0bertz@gentoo.org>
Subject: Re: [loongson-dev] Re: [loongson-PATCH-v3 17/25] add a machtype kernel command line argument
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Thu, 11 Jun 2009 23:16:55 +0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, Yan Hua <yanh@lemote.com>, Philippe Vachon <philippe@cowpig.ca>, Zhang Fuxin <zhangfx@lemote.com>, loongson-dev <loongson-dev@googlegroups.com>, Liu Junliang <liujl@lemote.com>, Erwan Lerale <erwan@thiscow.com>, Arnaud Patard <apatard@mandriva.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=6srUrnNQRV7a7nCW6yCN41Agu6I9jZYaYsLoc81Gtjw=; b=HptKQ4+EhFS14co1VYtUNxaQaXwo/KTt8pg5HaOFfGyqAHLWhLQj1S0pWD7QBw8DXl w63w/gjrOWsWBXwZoBq2Xpai4q72nLkc00yShpiYZz8hYEBmFaRTljv4YfIAxB0J/S16 54awlJAZukXaZsI9uIicOpm7pGzRHbV+xuTEA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=pqkMp4cscCcQAhKbk2k8R2vfKsvHu2uQfd1eYt0qXvCRFJ6rApdFDP4sgjrCAuEErR nWxGRcLXzJVLn0xHyyAJ4pPMuJ+qqzQi7BJj7AVcRCpflH0PCfWgvYxtOVpPMvZJ1FZh Zl1UflBo7huCZPP72SrgZ2nfVx+Hb57u4crD8=
In-reply-to: <20090611110914.GB20906@adriano.hkcable.com.hk>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1244120575.git.wuzj@lemote.com> <d1f4caa360114f843459dc71827b1175232a24be.1244120575.git.wuzj@lemote.com> <20090610154032.GB21877@adriano.hkcable.com.hk> <20090610203123.GA20906@adriano.hkcable.com.hk> <20090611110914.GB20906@adriano.hkcable.com.hk>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Thu, 2009-06-11 at 19:09 +0800, Zhang Le wrote:
> On 04:31 Thu 11 Jun     , Zhang Le wrote:
> 
> [...]
> 
> > 
> > diff --git a/arch/mips/loongson/common/machtype.c 
> > b/arch/mips/loongson/common/machtype.c
> > index d469dc7..34417cf 100644
> > --- a/arch/mips/loongson/common/machtype.c
> > +++ b/arch/mips/loongson/common/machtype.c
> 
> [...]
> 
> > -static __init int machname_setup(char *str)
> > +static __init int machtype_setup(char *str)
> 
> [...]
> 
> > -   for (index = 0;
> > -        index < MACHTYPE_TOTAL;
> > -        index++) {
> > -           if (strstr(str, machname[index]) != NULL) {
> > -                   mips_machtype = index;
> > -                   return 0;
> > +   for (; system_types[machtype]; machtype++)
> > +           if (strstr(str, system_types[machtype])) {
> 
> There is a problem here.
> 
> Because I have used "inches" instead of "inch" in system_types, if you insist
> on using "inch" when passing value to the machtype kernel parameter, this
> strstr() call's two parameters should be swapped:
> 
>              if (strstr(system_types[machtype], str)) {
> 

Acked.

thanks!
Wu Zhangjin

> 
> > +                   mips_machtype = machtype;
> > +                   break;
> >             }
> > -   }
> > -   return -1;
> > +   return 0;
> >  }
> >  
> > -__setup("machtype=", machname_setup);
> > +__setup("machtype=", machtype_setup);
> 
> 


<Prev in Thread] Current Thread [Next in Thread>