linux-mips
[Top] [All Lists]

Re: [PATCH] bc47xx : fix ssb irq setup

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] bc47xx : fix ssb irq setup
From: castet.matthieu@free.fr
Date: Thu, 11 Jun 2009 11:23:45 +0200
Cc: matthieu castet <castet.matthieu@free.fr>, linville@tuxdriver.com, Michael Buesch <mb@bu3sch.de>, linux-mips@linux-mips.org, netdev@vger.kernel.org, Daniel Mueller <daniel@danm.de>
In-reply-to: <200906111009.15080.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4A11DBD4.7070706@free.fr> <4A1ADBAE.6070101@free.fr> <200906110959.38132.florian@openwrt.org> <200906111009.15080.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Internet Messaging Program (IMP) 3.2.8
Quoting Florian Fainelli <florian@openwrt.org>:
> Le Thursday 11 June 2009 09:59:36 Florian Fainelli, vous avez écrit :
> > Hi Matthieu, Michael,
> >
> > Le Monday 25 May 2009 19:55:58 matthieu castet, vous avez écrit :
> > > Michael Buesch wrote:
> > > > On Tuesday 19 May 2009 00:06:12 matthieu castet wrote:
> > > >> Hi,
> > > >>
> > > >>
> > > >> [1] http://www.danm.de/files/src/bcm5365p/REPORTED_DEVICES
> > > >>
> > > >> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
> > > >
> > > > If this works on all devices, I'm OK with this. Please submit to
> > > > linville@tuxdriver.com You can add my ack.
> > >
> > > Well I have only a wl500gd.
> > > I have submit it on openwrt project in order to test in more devices.
> >
> > It makes the IPsec core work on my Netgear WGT634U and I did not see any
> > regression on a Linksys WRT54GS.
> >
> > Tested-by: Florian Fainelli <florian@openwrt.org>
>
> One minor thing, please remove the dump_irqs call, it is convenient for
> debugging to print the IRQ routing, but I find it a little too verbose for
> production. This can be a follow-up patch if you prefer not to respin it.

Well all x86 does something similar, with acpi dumping the pci interrupt Routing
Table even in production kernel.
But it can removed if people don't want it.


Matthieu

<Prev in Thread] Current Thread [Next in Thread>