linux-mips
[Top] [All Lists]

Re: add bcm47xx watchdog driver

To: matthieu castet <castet.matthieu@free.fr>
Subject: Re: add bcm47xx watchdog driver
From: Wim Van Sebroeck <wim@iguana.be>
Date: Wed, 10 Jun 2009 21:06:02 +0200
Cc: Florian Fainelli <florian@openwrt.org>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, biblbroks@sezampro.rs
In-reply-to: <4A2FFFDA.6010807@free.fr>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4A282D98.6020004@free.fr> <20090605124813.d7666ed0.akpm@linux-foundation.org> <4A29805D.60205@free.fr> <200906081615.45889.florian@openwrt.org> <20090610171732.GI16090@infomag.iguana.be> <4A2FFFDA.6010807@free.fr>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
Hi Matthieu,

>> +
>> +#define WDT_DEFAULT_TIME    30      /* seconds */
>> +#define WDT_MAX_TIME                255     /* seconds */
> Why have changed this from 256 to 255 ?

Since you use a timer to control the real watchdog, the wdt_time function is 
arbitraty anyway.
Most watchdog drivers use 0xFFFF. Since you only went to 256 it made more sense 
to have it as 0xFF which is 255.
We can make it 65535 also. 

>> +}
>> +
>> +static int bcm47xx_wdt_notify_sys(struct notifier_block *this,
>> +    nsigned long code, void *unused)
>        ^^^^
> Does this build ?

Nope. should be unsigned.

Kind regards,
Wim.


<Prev in Thread] Current Thread [Next in Thread>