linux-mips
[Top] [All Lists]

Re: add bcm47xx watchdog driver

To: Wim Van Sebroeck <wim@iguana.be>
Subject: Re: add bcm47xx watchdog driver
From: matthieu castet <castet.matthieu@free.fr>
Date: Wed, 10 Jun 2009 20:47:54 +0200
Cc: Florian Fainelli <florian@openwrt.org>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, biblbroks@sezampro.rs
In-reply-to: <20090610171732.GI16090@infomag.iguana.be>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4A282D98.6020004@free.fr> <20090605124813.d7666ed0.akpm@linux-foundation.org> <4A29805D.60205@free.fr> <200906081615.45889.florian@openwrt.org> <20090610171732.GI16090@infomag.iguana.be>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.19) Gecko/20081204 Iceape/1.1.14 (Debian-1.1.14-1)
Hi,

Wim Van Sebroeck wrote:
Hi Matthieu, Florian,

It works very well on my Netgear WGT634U, thanks !

Tested-by: Florian Fainelli <florian@openwrt.org>

I incorporated the changes of Andrew and did a clean-up here and there to keep 
checkpatch happy.
Could you test the attached diff to see that it still works.

Thanks,
Wim.


+
+#define WDT_DEFAULT_TIME       30      /* seconds */
+#define WDT_MAX_TIME           255     /* seconds */
Why have changed this from 256 to 255 ?

+}
+
+static int bcm47xx_wdt_notify_sys(struct notifier_block *this,
+       nsigned long code, void *unused)
       ^^^^
Does this build ?


Matthieu

<Prev in Thread] Current Thread [Next in Thread>