linux-mips
[Top] [All Lists]

Re: [loongson-PATCH-v3 10/25] split the loongson-specific part out

To: Zhang Le <r0bertz@gentoo.org>
Subject: Re: [loongson-PATCH-v3 10/25] split the loongson-specific part out
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Wed, 10 Jun 2009 20:39:30 +0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, Yan Hua <yanh@lemote.com>, Philippe Vachon <philippe@cowpig.ca>, Zhang Fuxin <zhangfx@lemote.com>, loongson-dev <loongson-dev@googlegroups.com>, Liu Junliang <liujl@lemote.com>, Erwan Lerale <erwan@thiscow.com>, Arnaud Patard <apatard@mandriva.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=/SJ5kNil9IQG7sI9MPdKBtt+Rh+lYb6xcypvztUr7v0=; b=CdFFk43aoqZWWej2rVGgIqG/bSHEwlZTTTNgUbtC8AUPDp4pjx5GXHzokmELB+vR3E BwMeQq4kfrK8JXW/T9B112J649eK79yUsUhG8dgCbw37LXp7VQuQmXbMMPOZ2AlJd9n3 2XUfRZFpmtxnKd2kFzpE2szRpWxkF58k45u7M=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=vQFGn+AvRtO5sWZzU0NGmVfQOm7NkE0DZsURn/7MTPecZeoxjBNKq/3bHLCEMyjdmV Le11sLV0EXea1uLIMHgYUC9vtOSeF+7aWaTRwb393iLZT0kCsZaf7ZYEn9gL9mtqIkJS Gjuqn3fx2LnN2WLDiAcX8uQvx6OSNmV+TknZo=
In-reply-to: <20090609175130.GC1287@adriano.hkcable.com.hk>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1244120575.git.wuzj@lemote.com> <cc26466a1817a94314d8e118dfcbe38d55190d62.1244120575.git.wuzj@lemote.com> <20090609175130.GC1287@adriano.hkcable.com.hk>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Wed, 2009-06-10 at 01:51 +0800, Zhang Le wrote:
> On 21:05 Thu 04 Jun     , wuzhangjin@gmail.com wrote:
> 
> [...]
> 
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> 
> [...]
> 
> Two cosmetic change suggestions:
> 
> > +config LOONGSON_SYSTEMS
> 
> To keep it in line with other CPU's, I suggest change LOONGSON_SYSTEMS to
> MACH_LOONGSON. This is really a matter of taste. So take it at your own
> discretion. And don't forget change all occurrences of CONFIG_LOONGSON_SYSTEMS
> to CONFIG_MACH_LOONGSON, too.
> 
> > +   bool "Loongson Based Machines"
> 
> There is no need to use capital letter in based and machines here.

seems better, will applied later :-)

best wishes,
Wu Zhangjin


<Prev in Thread] Current Thread [Next in Thread>