linux-mips
[Top] [All Lists]

Re: [loongson-PATCH-v3 10/25] split the loongson-specific part out

To: wuzhangjin@gmail.com
Subject: Re: [loongson-PATCH-v3 10/25] split the loongson-specific part out
From: Zhang Le <r0bertz@gentoo.org>
Date: Wed, 10 Jun 2009 01:51:31 +0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, Wu Zhangjin <wuzj@lemote.com>, Yan Hua <yanh@lemote.com>, Philippe Vachon <philippe@cowpig.ca>, Zhang Fuxin <zhangfx@lemote.com>, loongson-dev <loongson-dev@googlegroups.com>, Liu Junliang <liujl@lemote.com>, Erwan Lerale <erwan@thiscow.com>, Arnaud Patard <apatard@mandriva.com>
In-reply-to: <cc26466a1817a94314d8e118dfcbe38d55190d62.1244120575.git.wuzj@lemote.com>
Mail-followup-to: wuzhangjin@gmail.com, linux-mips@linux-mips.org, ralf@linux-mips.org, Wu Zhangjin <wuzj@lemote.com>, Yan Hua <yanh@lemote.com>, Philippe Vachon <philippe@cowpig.ca>, Zhang Fuxin <zhangfx@lemote.com>, loongson-dev <loongson-dev@googlegroups.com>, Liu Junliang <liujl@lemote.com>, Erwan Lerale <erwan@thiscow.com>, Arnaud Patard <apatard@mandriva.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1244120575.git.wuzj@lemote.com> <cc26466a1817a94314d8e118dfcbe38d55190d62.1244120575.git.wuzj@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.19 (2009-01-05)
On 21:05 Thu 04 Jun     , wuzhangjin@gmail.com wrote:

[...]

> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig

[...]

Two cosmetic change suggestions:

> +config LOONGSON_SYSTEMS

To keep it in line with other CPU's, I suggest change LOONGSON_SYSTEMS to
MACH_LOONGSON. This is really a matter of taste. So take it at your own
discretion. And don't forget change all occurrences of CONFIG_LOONGSON_SYSTEMS
to CONFIG_MACH_LOONGSON, too.

> +     bool "Loongson Based Machines"

There is no need to use capital letter in based and machines here.

Thanks!

-- 
Zhang, Le
Gentoo/Loongson Developer
http://zhangle.is-a-geek.org
0260 C902 B8F8 6506 6586 2B90 BC51 C808 1E4E 2973

Attachment: pgphYhnqum_KC.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>