| To: | castet.matthieu@free.fr |
|---|---|
| Subject: | Re: add bcm47xx watchdog driver |
| From: | Florian Fainelli <florian@openwrt.org> |
| Date: | Sat, 6 Jun 2009 12:58:02 +0200 |
| Cc: | wim@iguana.be, Linux Kernel list <linux-kernel@vger.kernel.org>, linux-mips@linux-mips.org, Aleksandar Radovanovic <biblbroks@sezampro.rs> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=VFHaxxXKqBqTxPUBcWeYIBsdIdLY1JfUBOIj56pfxZo=; b=YSNLGTwfUlA4zdiR9bQsouPoWAU7uFfCM52psvRZ6DC8eU7Mo3emKlAZSnfONnC0z4 SGgDXO1lMmGJA0IgIn+CoSXOW30VW4tm9BcuXi1YilkBzVCdAygssGiYDEiBrKIDHBbe kmqSrxaUTN/mVDuvEvG/OLA3ezb0XKhRyD/g4= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=Zkq3/8TIYEagIBmkOUQ7yXRmrNrc6Ug8fF9DFp0sgbg4bUNBsOlQ9XNVyiSgVccJPh TyQGK23etKVCFeOPjQvJguf7ZUgdZtuwsE4Aw36k+M6WHyNGDvz5FHuI6fWvX77ocL+A F0BA93aE2dygsCuHwn8mcgdncPqE1hzYx9CbA= |
| In-reply-to: | <1244213922.4a2932a272094@imp.free.fr> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <4A282D98.6020004@free.fr> <200906051558.02303.florian@openwrt.org> <1244213922.4a2932a272094@imp.free.fr> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | KMail/1.9.9 |
Le Friday 05 June 2009 16:58:42 castet.matthieu@free.fr, vous avez écrit : > Hi Florian, > > Quoting Florian Fainelli <florian@openwrt.org>: > > Your driver looks good, could you turn this into a platform device/driver > > instead ? You declare bcm47xx_wdt_platform_device which is unused and you > > also declare a MODULE_ALIAS which suggets it is one. > > What's the advantage of using platform device/driver ? > Not all watchdog driver use it (for example softdog). > This seems useless in this case because the driver don't have any resource, > don't care about suspend/resume and add complexity in the code (2 registers > in module probe, ...). Indeed, I was suggesting that either you turn it into a full platform driver or your remove references to it (bcm47xx_wdt_platform_device and MODULE_ALIAS). -- Best regards, Florian Fainelli Email : florian@openwrt.org http://openwrt.org ------------------------------- |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] SIBYTE: remove irritating printk from set_affinity, Thomas Bogendoerfer |
|---|---|
| Next by Date: | [PATCH 1/5] Alchemy: remove unused au1000_gpio.h header, Manuel Lauss |
| Previous by Thread: | Re: add bcm47xx watchdog driver, castet . matthieu |
| Next by Thread: | Re: add bcm47xx watchdog driver v2, matthieu castet |
| Indexes: | [Date] [Thread] [Top] [All Lists] |