linux-mips
[Top] [All Lists]

Re: add bcm47xx watchdog driver

To: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: add bcm47xx watchdog driver
From: matthieu castet <castet.matthieu@free.fr>
Date: Fri, 05 Jun 2009 22:03:49 +0200
Cc: wim@iguana.be, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, biblbroks@sezampro.rs
In-reply-to: <20090605125023.d968c58e.akpm@linux-foundation.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4A282D98.6020004@free.fr> <20090605125023.d968c58e.akpm@linux-foundation.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.19) Gecko/20081204 Iceape/1.1.14 (Debian-1.1.14-1)
Andrew Morton wrote:
On Thu, 04 Jun 2009 22:24:56 +0200
matthieu castet <castet.matthieu@free.fr> wrote:

This add watchdog driver for broadcom 47xx device.
It uses the ssb subsytem to access embeded watchdog device.

...

--- linux-2.6.orig/drivers/watchdog/Kconfig     2009-05-25 22:22:02.000000000 
+0200
+++ linux-2.6/drivers/watchdog/Kconfig  2009-05-25 22:26:06.000000000 +0200
@@ -764,6 +764,12 @@
        help
          Hardware driver for the built-in watchdog timer on TXx9 MIPS SoCs.
+config BCM47XX_WDT
+    tristate "Broadcom BCM47xx Watchdog Timer"
+    depends on BCM47XX
+    help
+      Hardware driver for the Broadcom BCM47xx Watchog Timer.

Shouldn't there be some SSB dependencies in Kconfig here?
No, because :
config BCM47XX
    bool "BCM47XX based boards"
[...]
    select SSB
    select SSB_DRIVER_MIPS
    select SSB_DRIVER_EXTIF
    select SSB_EMBEDDED
    select SSB_PCICORE_HOSTMODE if PCI

<Prev in Thread] Current Thread [Next in Thread>