[Top] [All Lists]

Re: add bcm47xx watchdog driver

To: Florian Fainelli <>
Subject: Re: add bcm47xx watchdog driver
Date: Fri, 05 Jun 2009 16:58:42 +0200
Cc: matthieu castet <>,, Linux Kernel list <>,, Aleksandar Radovanovic <>
In-reply-to: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Internet Messaging Program (IMP) 3.2.8
Hi Florian,

Quoting Florian Fainelli <>:

> Your driver looks good, could you turn this into a platform device/driver
> instead ? You declare bcm47xx_wdt_platform_device which is unused and you
> also declare a MODULE_ALIAS which suggets it is one.
What's the advantage of using platform device/driver ?
Not all watchdog driver use it (for example softdog).
This seems useless in this case because the driver don't have any resource,
don't care about suspend/resume and add complexity in the code (2 registers in
module probe, ...).


<Prev in Thread] Current Thread [Next in Thread>