| To: | Florian Fainelli <florian@openwrt.org> |
|---|---|
| Subject: | Re: add bcm47xx watchdog driver |
| From: | castet.matthieu@free.fr |
| Date: | Fri, 05 Jun 2009 16:58:42 +0200 |
| Cc: | matthieu castet <castet.matthieu@free.fr>, wim@iguana.be, Linux Kernel list <linux-kernel@vger.kernel.org>, linux-mips@linux-mips.org, Aleksandar Radovanovic <biblbroks@sezampro.rs> |
| In-reply-to: | <200906051558.02303.florian@openwrt.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <4A282D98.6020004@free.fr> <200906051558.02303.florian@openwrt.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Internet Messaging Program (IMP) 3.2.8 |
Hi Florian, Quoting Florian Fainelli <florian@openwrt.org>: > > Your driver looks good, could you turn this into a platform device/driver > instead ? You declare bcm47xx_wdt_platform_device which is unused and you > also declare a MODULE_ALIAS which suggets it is one. What's the advantage of using platform device/driver ? Not all watchdog driver use it (for example softdog). This seems useless in this case because the driver don't have any resource, don't care about suspend/resume and add complexity in the code (2 registers in module probe, ...). Matthieu |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: add bcm47xx watchdog driver, Florian Fainelli |
|---|---|
| Next by Date: | Re: add bcm47xx watchdog driver v2, matthieu castet |
| Previous by Thread: | Re: add bcm47xx watchdog driver, Florian Fainelli |
| Next by Thread: | Re: add bcm47xx watchdog driver, Florian Fainelli |
| Indexes: | [Date] [Thread] [Top] [All Lists] |