linux-mips
[Top] [All Lists]

Re: add bcm47xx watchdog driver

To: matthieu castet <castet.matthieu@free.fr>
Subject: Re: add bcm47xx watchdog driver
From: Florian Fainelli <florian@openwrt.org>
Date: Fri, 5 Jun 2009 15:58:01 +0200
Cc: wim@iguana.be, Linux Kernel list <linux-kernel@vger.kernel.org>, linux-mips@linux-mips.org, Aleksandar Radovanovic <biblbroks@sezampro.rs>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=i1oHTJrvjZV7K+NstYFEh8ZuXsfianMZ6AGjzDdHKmU=; b=nFafPkOsZKaFk+znH28TULHJ003TVm0tGc8F5SQ6O8aYr4PMb21zkFEBl2qlAKV5UL fcZmJJnLDCW22o8+TJ1OpweZGDRgsO375mW2JzqtO+bSKrDxsnyv6j/Ytnlsuaxeevq6 YS2N/idERs1ByARB0ndEE1vUFqQHZZTEnqZPY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=gsLrRkfuU6p84wKIrlf1TT0biTqQ7msW11jAOtyUJblkPhLKtqrBCkRohVXue56rOL mSBJOoP6xMwI5PjxuOXnZDljYT/g2InALIoHAPkpBkJFQqQlFyKDlRvRbLtQrN0xozNa p2RMmCzdRd0vSCAajKHyRvRKgt79dbeCzqbTY=
In-reply-to: <4A282D98.6020004@free.fr>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4A282D98.6020004@free.fr>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Salut Matthieu,

Le Thursday 04 June 2009 22:24:56 matthieu castet, vous avez écrit :
> This add watchdog driver for broadcom 47xx device.
> It uses the ssb subsytem to access embeded watchdog device.
>
> Because the watchdog timeout is very short (about 2s), a soft timer is used
> to increase the watchdog period.
>
> Note : A patch for exporting the ssb_watchdog_timer_set will
> be submitted on next linux-mips merge. Without this patch it can't
> be build as a module.

Your driver looks good, could you turn this into a platform device/driver 
instead ? You declare bcm47xx_wdt_platform_device which is unused and you 
also declare a MODULE_ALIAS which suggets it is one.

You are also missing your name in both the header the the MODULE_AUTHOR macro.
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

<Prev in Thread] Current Thread [Next in Thread>