linux-mips
[Top] [All Lists]

Re: [PATCH] Hibernation Support in mips system

To: wuzhangjin@gmail.com
Subject: Re: [PATCH] Hibernation Support in mips system
From: Pavel Machek <pavel@ucw.cz>
Date: Wed, 3 Jun 2009 13:24:15 +0200
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, Arnaud Patard <apatard@mandriva.com>, Atsushi Nemoto <anemo@mba.ocn.ne.jp>, yan hua <yanh@lemote.com>, Zhang Fuxin <zhangfx@lemote.com>, Wu Zhangjin <wuzj@lemote.com>, Hongbing Hu <huhb@lemote.com>
In-reply-to: <1243956702-16276-1-git-send-email-wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1243956702-16276-1-git-send-email-wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue 2009-06-02 23:31:42, wuzhangjin@gmail.com wrote:
> From: Wu Zhangjin <wuzj@lemote.com>
> 
> This is originally pulled from the to-mips branch of
> http://dev.lemote.com/code/linux_loongson, only a few coding style
> tuning under the support of script/checkpatch.pl
> 
> as the feedback from Atsushi Nemoto,Yanhua and Pavel Machek, some changes
> have been done by Hu Hongbing(the original author of mips-specific STD)
> from Lemote.com. this patch apply the changes, which include:
> 
> Reviewed-by: Pavel Machek <pavel@ucw.cz>

The patch looks ok, but I don't think I offered that tag before. You
can add it now.

> @@ -0,0 +1,31 @@
> +/*
> + * Suspend support specific for mips.

"Hibernation support"? Copyright, GPL, author info?

> +#include <linux/mm.h>
> +#include <linux/suspend.h>
> +#include <asm/mipsregs.h>
> +#include <asm/page.h>
> +#include <asm/suspend.h>
> +#include <asm/ptrace.h>
> +
> +static uint32_t saved_status;

"u32" please.

                                                                        Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

<Prev in Thread] Current Thread [Next in Thread>