linux-mips
[Top] [All Lists]

Re: [PATCH 10/10] bcm63xx: clarify meaning of the magical value in ehci-

To: Maxime Bizon <mbizon@freebox.fr>
Subject: Re: [PATCH 10/10] bcm63xx: clarify meaning of the magical value in ehci-bcm63xx.c
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 1 Jun 2009 20:12:41 +0200
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=4wc4uzcAxNxN4F9ULcIYFLjDTmV0aCdZwDUkwvcqYnU=; b=lqsdrKD0RKApWQF59hOPdws1NBK21/trqD3JNWBcOg7hMPUd2XpBAPI7fcID1H+vJY RY59f9urQHTjogeDmPDg7GSVIilhYcd28hntBj1bau0D0xIzeWAVqWrxQasntCqVTFtJ YmcuzRuQjjGN8Q0f0/Xt1BHln3NKL8TSuIFxs=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=VXbIC5viDjIUjNZOgJO+xlhYWrXMMCvigBcRD35GBD/BOZK2C5IU103s0N3RISn4lY FB9Pmw/7WC2rLtDSqVrG+0qFiVOlWR4w/M+3P2of1EUmJLglIh63EGG1xqCgA66A1SG7 Liw9zue/gKso6sn8+QgQjXWbM1aPFubQuo5sQ=
In-reply-to: <1243876918-9905-11-git-send-email-mbizon@freebox.fr>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1243876918-9905-1-git-send-email-mbizon@freebox.fr> <1243876918-9905-11-git-send-email-mbizon@freebox.fr>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Le Monday 01 June 2009 19:21:58 Maxime Bizon, vous avez écrit :
> USB maintainer asked for clarification of the magic value used during
> USB init. Be clear about the source of it.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>

Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
>  drivers/usb/host/ehci-bcm63xx.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-bcm63xx.c
> b/drivers/usb/host/ehci-bcm63xx.c index 8a62c0a..5a03fdd 100644
> --- a/drivers/usb/host/ehci-bcm63xx.c
> +++ b/drivers/usb/host/ehci-bcm63xx.c
> @@ -78,7 +78,9 @@ static int __devinit ehci_hcd_bcm63xx_drv_probe(struct
> platform_device *pdev) reg |= USBH_PRIV_SWAP_EHCI_ENDN_MASK;
>       bcm_rset_writel(RSET_USBH_PRIV, reg, USBH_PRIV_SWAP_REG);
>
> -     /* don't ask... */
> +     /* the magic value comes for the original vendor BSP and is
> +      * needed for USB to work. Datasheet does not help, so the
> +      * magic value is used as-is. */
>       bcm_rset_writel(RSET_USBH_PRIV, 0x1c0020, USBH_PRIV_TEST_REG);
>
>       hcd = usb_create_hcd(&ehci_bcm63xx_hc_driver, &pdev->dev, "bcm63xx");



-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

<Prev in Thread] Current Thread [Next in Thread>