linux-mips
[Top] [All Lists]

Re: [PATCH 07/10] bcm63xx: clarify meaning of the magical value in ohci-

To: Maxime Bizon <mbizon@freebox.fr>
Subject: Re: [PATCH 07/10] bcm63xx: clarify meaning of the magical value in ohci-bcm63xx.c
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 1 Jun 2009 20:11:51 +0200
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=ABTBV+PxGmew6DWQrYZiZkijTxvLHpxV3+ZbJO29VVU=; b=BbGDLFjL1PqGZ4xZy/lZbdrzKi+Kwjxx/MN3GrnRXO8clTldbLKaei/nH9U5odadsG 2dUbX4YTvruQcKelOmairl0cBWK4QbFB1llLCleH/st9ENjVyUN6cEldlKuKK/EGnXRQ A9nASw3rOBE3tDfm+8epU1g1U1IarNVhfUz88=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=jab3sLJ9fnp6x+Jkz+6A22zfQiyJtbMmvYoNQfOx7ah/Y/YyjgJRqUlXo9nciHLCaq sGoKrxJm8BCRAEZ3wDkuQ7ACOOZlRQmBpdg7cRADMEBeMfmnHWkjAC9a6zpu2xNM6Chj 6KldX64y1QtkLtRYULClF2FEPMTYOwd5AJu04=
In-reply-to: <1243876918-9905-8-git-send-email-mbizon@freebox.fr>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1243876918-9905-1-git-send-email-mbizon@freebox.fr> <1243876918-9905-8-git-send-email-mbizon@freebox.fr>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Le Monday 01 June 2009 19:21:55 Maxime Bizon, vous avez écrit :
> USB maintainer asked for clarification  of the magic value used during
> USB init. Be clear about the source of it.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>

Acked-by: Florian Fainelli <florian@openwrt.org>
> ---
>  drivers/usb/host/ohci-bcm63xx.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-bcm63xx.c
> b/drivers/usb/host/ohci-bcm63xx.c index d48c8ac..bd66d5a 100644
> --- a/drivers/usb/host/ohci-bcm63xx.c
> +++ b/drivers/usb/host/ohci-bcm63xx.c
> @@ -85,7 +85,9 @@ static int __devinit ohci_hcd_bcm63xx_drv_probe(struct
> platform_device *pdev) reg &= ~USBH_PRIV_SWAP_OHCI_ENDN_MASK;
>               reg |= USBH_PRIV_SWAP_OHCI_DATA_MASK;
>               bcm_rset_writel(RSET_USBH_PRIV, reg, USBH_PRIV_SWAP_REG);
> -             /* don't ask... */
> +             /* the magic value comes for the original vendor BSP
> +              * and is needed for USB to work. Datasheet does not
> +              * help, so the magic value is used as-is. */
>               bcm_rset_writel(RSET_USBH_PRIV, 0x1c0020, USBH_PRIV_TEST_REG);
>       } else
>               return 0;



-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

<Prev in Thread] Current Thread [Next in Thread>