linux-mips
[Top] [All Lists]

Re: [PATCH 02/10] bcm63xx: use napi_complete instead of __napi_complete

To: Maxime Bizon <mbizon@freebox.fr>
Subject: Re: [PATCH 02/10] bcm63xx: use napi_complete instead of __napi_complete
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 1 Jun 2009 20:09:02 +0200
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=eqSrgNkG+3/6PvNeluhcdY+QMGw+vKiLIfzcu2FV5ko=; b=M2TpWSGr6zukVX71gEQg+Iak1QlscCmUGLzIXrvxg1de1kXty0l8lBeHEeHpzwCPbs spZBIV7/ztFiK7itvKaOBxJrD/Hgh9pGa6Sz5Xt1Df4+leKENuNkxErdDcWXNgby1ZQb JjoUE3bYyEFOu7js+NdIYE8ZJWWTIYz0q55JA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=Bqh02IpC2C+QHVtOboapAbqpDqalawWyQjfZJTE4xHvux+AaekGnuz93ZI0VGLxpVc bfHfadwnIl3GSsM3VOG52CCXy5rM/DotTF50FWmNoTDPaIC0UAZm2eMEURpg4P4nbxJe AYwpiLV5QUFwP1XqIPJG2zhJ+QFfncad8HtlQ=
In-reply-to: <1243876918-9905-3-git-send-email-mbizon@freebox.fr>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1243876918-9905-1-git-send-email-mbizon@freebox.fr> <1243876918-9905-3-git-send-email-mbizon@freebox.fr>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Le Monday 01 June 2009 19:21:50 Maxime Bizon, vous avez écrit :
> We're not disabling IRQ, so we must call the irq safe flavour of
> napi_complete.
>
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>

Tested-by: Florian Fainelli <florian@openwrt.org>
Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
>  drivers/net/bcm63xx_enet.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/bcm63xx_enet.c b/drivers/net/bcm63xx_enet.c
> index a91f909..20e08ef 100644
> --- a/drivers/net/bcm63xx_enet.c
> +++ b/drivers/net/bcm63xx_enet.c
> @@ -450,7 +450,7 @@ static int bcm_enet_poll(struct napi_struct *napi, int
> budget)
>
>       /* no more packet in rx/tx queue, remove device from poll
>        * queue */
> -     __napi_complete(napi);
> +     napi_complete(napi);
>
>       /* restore rx/tx interrupt */
>       enet_dma_writel(priv, ENETDMA_IR_PKTDONE_MASK,

<Prev in Thread] Current Thread [Next in Thread>