| To: | linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org> |
|---|---|
| Subject: | [PATCH 07/10] bcm63xx: clarify meaning of the magical value in ohci-bcm63xx.c |
| From: | Maxime Bizon <mbizon@freebox.fr> |
| Date: | Mon, 1 Jun 2009 19:21:55 +0200 |
| Cc: | Florian Fainelli <florian@openwrt.org>, Maxime Bizon <mbizon@freebox.fr> |
| In-reply-to: | <1243876918-9905-1-git-send-email-mbizon@freebox.fr> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1243876918-9905-1-git-send-email-mbizon@freebox.fr> |
| Sender: | linux-mips-bounce@linux-mips.org |
USB maintainer asked for clarification of the magic value used during
USB init. Be clear about the source of it.
Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
---
drivers/usb/host/ohci-bcm63xx.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ohci-bcm63xx.c b/drivers/usb/host/ohci-bcm63xx.c
index d48c8ac..bd66d5a 100644
--- a/drivers/usb/host/ohci-bcm63xx.c
+++ b/drivers/usb/host/ohci-bcm63xx.c
@@ -85,7 +85,9 @@ static int __devinit ohci_hcd_bcm63xx_drv_probe(struct
platform_device *pdev)
reg &= ~USBH_PRIV_SWAP_OHCI_ENDN_MASK;
reg |= USBH_PRIV_SWAP_OHCI_DATA_MASK;
bcm_rset_writel(RSET_USBH_PRIV, reg, USBH_PRIV_SWAP_REG);
- /* don't ask... */
+ /* the magic value comes for the original vendor BSP
+ * and is needed for USB to work. Datasheet does not
+ * help, so the magic value is used as-is. */
bcm_rset_writel(RSET_USBH_PRIV, 0x1c0020, USBH_PRIV_TEST_REG);
} else
return 0;
--
1.6.0.4
|
| Previous by Date: | More updates to bcm63xx support (resend), Maxime Bizon |
|---|---|
| Next by Date: | [PATCH 06/10] bcm63xx: don't set bus type in ohci-bcm63xx.c, Maxime Bizon |
| Previous by Thread: | Re: [PATCH 02/10] bcm63xx: use napi_complete instead of __napi_complete, Florian Fainelli |
| Next by Thread: | Re: [PATCH 07/10] bcm63xx: clarify meaning of the magical value in ohci-bcm63xx.c, Florian Fainelli |
| Indexes: | [Date] [Thread] [Top] [All Lists] |