linux-mips
[Top] [All Lists]

Re: [PATCH 07/10] bcm63xx: fix typo when printing CPU frequency

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 07/10] bcm63xx: fix typo when printing CPU frequency
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 1 Jun 2009 15:46:18 +0100
Cc: linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>
In-reply-to: <200905312029.50326.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200905312029.50326.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, May 31, 2009 at 08:29:49PM +0200, Florian Fainelli wrote:

> This patch corrects the comment about the CPU
> frequency which is actually printed in Hz and not MHz.
> 
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/arch/mips/bcm63xx/cpu.c b/arch/mips/bcm63xx/cpu.c
> index 0a403dd..410c788 100644
> --- a/arch/mips/bcm63xx/cpu.c
> +++ b/arch/mips/bcm63xx/cpu.c
> @@ -238,7 +238,7 @@ void __init bcm63xx_cpu_init(void)
>  
>       printk(KERN_INFO "Detected Broadcom 0x%04x CPU revision %02x\n",
>              bcm63xx_cpu_id, bcm63xx_cpu_rev);
> -     printk(KERN_INFO "CPU frequency is %u MHz\n",
> +     printk(KERN_INFO "CPU frequency is %u Hz\n",

While technically ok I would suggest to print the number in MHz.  Acuracy
probably doesn't matter so even rounding to whole MHz would be ok.

Want me to apply anyway?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>