linux-mips
[Top] [All Lists]

Re: [PATCH 06/10] bcm63xx: zero initialize mac_addr_used.

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 06/10] bcm63xx: zero initialize mac_addr_used.
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 1 Jun 2009 15:41:54 +0100
Cc: linux-mips@linux-mips.org, Maxime Bizon <mbizon@freebox.fr>
In-reply-to: <200905312029.07558.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200905312029.07558.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, May 31, 2009 at 08:29:07PM +0200, Florian Fainelli wrote:

> This patch initializes mac_addr_used to zero, the checks
> against it later would not work properly.
> 
> Signed-off-by: Maxime Bizon <mbizon@freebox.fr>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/arch/mips/bcm63xx/boards/board_bcm963xx.c 
> b/arch/mips/bcm63xx/boards/board_bcm963xx.c
> index 78a40e7..298804a 100644
> --- a/arch/mips/bcm63xx/boards/board_bcm963xx.c
> +++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c
> @@ -32,7 +32,7 @@
>  #define PFX  "board_bcm963xx: "
>  
>  static struct bcm963xx_nvram nvram;
> -static unsigned int mac_addr_used;
> +static unsigned int mac_addr_used = 0;

Ditto - the variable defaults to zero.  Explicit initialization however
will inflate the .data section.  Dropped.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 06/10] bcm63xx: zero initialize mac_addr_used., Ralf Baechle <=