| To: | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Subject: | Re: [PATCH] hwrng: Add TX4939 RNG driver |
| From: | Herbert Xu <herbert@gondor.apana.org.au> |
| Date: | Sun, 31 May 2009 11:30:22 +1000 |
| Cc: | Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org |
| In-reply-to: | <20090529162907.9cb1bba2.akpm@linux-foundation.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1243350141-883-1-git-send-email-anemo@mba.ocn.ne.jp> <20090529162907.9cb1bba2.akpm@linux-foundation.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Fri, May 29, 2009 at 04:29:07PM -0700, Andrew Morton wrote:
>
> > +static u64 read_rng(void __iomem *base, unsigned int offset)
> > +{
> > + /* Caller must disable interrupts */
> > + return ____raw_readq(base + offset);
> > +}
>
> What is the reasoning behind the local_irq_disable() requirement?
>
> Because I'm wondering whether this is safe on SMP?
Yes I'd like to see this fixed before adding this patch.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: ld: non-dynamic relocations refer to dynamic symbol, Kevin Cernekee |
|---|---|
| Next by Date: | Re: [PATCH v2 2/6] mips dynamic function tracer support, Wang Liming |
| Previous by Thread: | Re: [PATCH] hwrng: Add TX4939 RNG driver, Andrew Morton |
| Next by Thread: | Re: [PATCH] hwrng: Add TX4939 RNG driver, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |