linux-mips
[Top] [All Lists]

Re: [PATCH] mips-specific ftrace support

To: Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] mips-specific ftrace support
From: Thomas Gleixner <tglx@linutronix.de>
Date: Thu, 28 May 2009 16:45:37 +0200 (CEST)
Cc: wuzhangjin@gmail.com, linux-mips@linux-mips.org, LKML <linux-kernel@vger.kernel.org>, Ralf Baechle <ralf@linux-mips.org>, Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>, Nicholas Mc Guire <der.herr@hofr.at>, wuzj@lemote.com
In-reply-to: <alpine.DEB.2.00.0905280948410.27708@gandalf.stny.rr.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <73465d64a9a6773936f5eab3735a69f651c13187.1243458732.git.wuzj@lemote.com> <alpine.DEB.2.00.0905280948410.27708@gandalf.stny.rr.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Thu, 28 May 2009, Steven Rostedt wrote:
> On Thu, 28 May 2009, wuzhangjin@gmail.com wrote:
> Could you possibly break this patch up into porting the tracers one by 
> one. That is:
> 
> First patch: make function tracing work.
> Second patch: make dynamic tracing work.
> Third patch: add Function graph tracing.
> Forth patch: the time stamp updates
> 
> This would make things a lot easier to review, and if one of the changes 
> breaks something, it will be easier to bisect.

> >  include/linux/clocksource.h    |    4 +-
> >  kernel/sched_clock.c           |    2 +-
> >  kernel/trace/ring_buffer.c     |    3 +-
> >  kernel/trace/trace_clock.c     |    2 +-
> >  scripts/Makefile.build         |    1 +
> >  scripts/recordmcount.pl        |   31 +++-

The changes to these generic files need to be separate as well.

Thanks,

        tglx

<Prev in Thread] Current Thread [Next in Thread>