linux-mips
[Top] [All Lists]

Re: [PATCH] rb532: fix irq number check in rb532_set_type

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] rb532: fix irq number check in rb532_set_type
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 28 May 2009 12:37:54 +0200
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=0IOrSEpUtrzOHrmn2Jzo4crGgpKsnh5bEfQC/xEX+kI=; b=Q1kZw1e5O485AQ/39Qam9IZPniLz/V5QPARH9Sk4WdMJiD9y+rRUuFhJ0MjO+nHnxb tifEiVIb9uCEz9NF9CxLc058R4XAgvhw0Dzy3SsQhWT9n9mtE0sb1ekGJ/arndFw0xQ1 YvO4At74osFgWFkxN96o3DtsCe4V+p+DAaDEI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=Nxy9jEr5Z4XIb/FuEFLILFE5lF3uY01AAPOLOlqQJIE1qNbVRPSd8BatiGpIJFmuOK O7QTnTWu+3P3SJD9uIFOQ2c5pco2EzNMtQVPJQZYnjJfKf7qLm45tGjpnW+DgUM6HHPM NkVlXj3crjHM2NzMNCPsCQPh39w4igMaSC4mI=
In-reply-to: <20090527131535.GC7755@linux-mips.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200905271414.07074.florian@openwrt.org> <20090527131535.GC7755@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Le Wednesday 27 May 2009 15:15:35 Ralf Baechle, vous avez écrit :
> On Wed, May 27, 2009 at 02:14:06PM +0200, Florian Fainelli wrote:
> > We only have 14 GPIO interrupt sources numbered
> > from 0 to 13. Therefore the check against irq_nr
> > in rb532_set_type is off-by-one. This fixes a mistake
> > introduced by commit 1b4f571632ffb0caa4170d886694f2555c0d9a4b.
>
> Thanks; I've folded this patch into your old patch.

Thank you !

>
> A note on commit IDs on the -queue tree.  The -queue tree is really
> maintained in quilt and respun every time I change any of the commits
> on it.  This means the commit IDs will also change, so they should be
> considered volatile.

I will take that into account next time, thanks for fixing this.
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

<Prev in Thread] Current Thread [Next in Thread>