Re: [loongson-PATCH-v2 06/23] replace tons of magic numbers by understandable symbols

[Wu Zhangjin <wuzhangjin@gmail.com>]

On Wed, 2009-05-27 at 11:27 +0200, Arnaud Patard wrote:
> wuzhangjin@gmail.com writes:
> Hi,
> 
> [...]
> 
> > diff --git a/arch/mips/include/asm/mach-loongson/machine.h 
> > b/arch/mips/include/asm/mach-loongson/machine.h
> > new file mode 100644
> > index 0000000..5f2cd3a
> > --- /dev/null
> > +++ b/arch/mips/include/asm/mach-loongson/machine.h
> > @@ -0,0 +1,27 @@
> > +/*
> > + * board-specific header file
> > + *
> > + * Copyright (c) 2009 Wu Zhangjin <wuzj@lemote.com>
> > + *
> > + * This program is free software; you can redistribute it
> > + * and/or modify it under the terms of the GNU General
> > + * Public License as published by the Free Software
> > + * Foundation; either version 2 of the License, or (at your
> > + * option) any later version.
> > + */
> > +
> > +#ifndef __MACHINE_H
> > +#define __MACHINE_H
> > +
> > +#define MACH_NAME                  "lemote-fuloong(2e)"
> > +
> > +#define LOONGSON_UART_BASE         0x1fd003f8
> 
> Why not using LOONGSON_PCIIO_BASE+0x3f8 ?
> 

yes, i just tuned arch/mips/include/asm/mach-loongson/machine.h and the
relative file arch/mips/loongson/common/serial.c as above.

thx!
Wu Zhangjin