| To: | Florian Fainelli <florian@openwrt.org> |
|---|---|
| Subject: | Re: [PATCH] rb532: fix irq number check in rb532_set_type |
| From: | Ralf Baechle <ralf@linux-mips.org> |
| Date: | Wed, 27 May 2009 14:15:35 +0100 |
| Cc: | linux-mips@linux-mips.org |
| In-reply-to: | <200905271414.07074.florian@openwrt.org> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <200905271414.07074.florian@openwrt.org> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Wed, May 27, 2009 at 02:14:06PM +0200, Florian Fainelli wrote: > We only have 14 GPIO interrupt sources numbered > from 0 to 13. Therefore the check against irq_nr > in rb532_set_type is off-by-one. This fixes a mistake > introduced by commit 1b4f571632ffb0caa4170d886694f2555c0d9a4b. Thanks; I've folded this patch into your old patch. A note on commit IDs on the -queue tree. The -queue tree is really maintained in quilt and respun every time I change any of the commits on it. This means the commit IDs will also change, so they should be considered volatile. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] rb532: fix irq number check in rb532_set_type, Florian Fainelli |
|---|---|
| Next by Date: | Re: [loongson-PATCH-v2 20/23] add gcc 4.4 support for MIPS and loongson, Wu Zhangjin |
| Previous by Thread: | [PATCH] rb532: fix irq number check in rb532_set_type, Florian Fainelli |
| Next by Thread: | Re: [PATCH] rb532: fix irq number check in rb532_set_type, Florian Fainelli |
| Indexes: | [Date] [Thread] [Top] [All Lists] |