linux-mips
[Top] [All Lists]

Re: [loongson-PATCH-v2 06/23] replace tons of magic numbers by understan

To: wuzhangjin@gmail.com
Subject: Re: [loongson-PATCH-v2 06/23] replace tons of magic numbers by understandable symbols
From: Arnaud Patard <apatard@mandriva.com>
Date: Wed, 27 May 2009 11:27:58 +0200
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Wu Zhangjin <wuzj@lemote.com>, Yan Hua <yanh@lemote.com>, Philippe Vachon <philippe@cowpig.ca>, Zhang Le <r0bertz@gentoo.org>, Zhang Fuxin <zhangfx@lemote.com>, loongson-dev <loongson-dev@googlegroups.com>, Nicholas Mc Guire <der.herr@hofr.at>, Liu Junliang <liujl@lemote.com>, Erwan Lerale <erwan@thiscow.com>
In-reply-to: <943d884878d1e8ccec9c11732669c5ec35913314.1243362545.git.wuzj@lemote.com> (wuzhangjin@gmail.com's message of "Wed, 27 May 2009 03:04:58 +0800")
Organization: Mandriva
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1243362545.git.wuzj@lemote.com> <943d884878d1e8ccec9c11732669c5ec35913314.1243362545.git.wuzj@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/22.1 (gnu/linux)
wuzhangjin@gmail.com writes:
Hi,

[...]

> diff --git a/arch/mips/include/asm/mach-loongson/machine.h 
> b/arch/mips/include/asm/mach-loongson/machine.h
> new file mode 100644
> index 0000000..5f2cd3a
> --- /dev/null
> +++ b/arch/mips/include/asm/mach-loongson/machine.h
> @@ -0,0 +1,27 @@
> +/*
> + * board-specific header file
> + *
> + * Copyright (c) 2009 Wu Zhangjin <wuzj@lemote.com>
> + *
> + * This program is free software; you can redistribute it
> + * and/or modify it under the terms of the GNU General
> + * Public License as published by the Free Software
> + * Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
> +
> +#ifndef __MACHINE_H
> +#define __MACHINE_H
> +
> +#define MACH_NAME                    "lemote-fuloong(2e)"
> +
> +#define LOONGSON_UART_BASE           0x1fd003f8

Why not using LOONGSON_PCIIO_BASE+0x3f8 ?

Arnaud

<Prev in Thread] Current Thread [Next in Thread>