linux-mips
[Top] [All Lists]

Re: [PATCH 4/4] Alchemy: xxs1500: use linux gpio api.

To: Manuel Lauss <mano@roarinelk.homelinux.net>
Subject: Re: [PATCH 4/4] Alchemy: xxs1500: use linux gpio api.
From: Florian Fainelli <florian@openwrt.org>
Date: Sat, 23 May 2009 13:18:17 +0200
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=h9XO/pJ8Nzos439L9vzymIBMvvidUDpDcnqkkCfhlOY=; b=uV2vPcO55iuoVmfYK0ooRvVq+EGE2QABEnpSqcG/uxC20ruWAxr70jMAjwECCw2bCy BAQW1ZjbwHoRHo3SmHmL3etCUbGs6lhUmXiMjMnqdzDwRAhuOn//MPrWvUr+hX9qQ5Nj rvxrTX5c8EsFzO/gYEvSvO6rEhTa6COR3loBo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=duu712xnO7SnOO99ox5+fayB/GhO+r8ZCGDdXkr3m2b2rq+IDyTvCUp62lQgg9KQU2 gQtj+S/FYHP3xQvQtYp7S3TopiV8/HeVEfGoKUmcNfUb1mxI6KOdMZosKYC2T8MJ+AxI UWF9HIdaDm2n8N288p3ja8V6m3p4Aqi8OYLCs=
In-reply-to: <1243023899-10343-4-git-send-email-mano@roarinelk.homelinux.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1243023899-10343-1-git-send-email-mano@roarinelk.homelinux.net> <1243023899-10343-3-git-send-email-mano@roarinelk.homelinux.net> <1243023899-10343-4-git-send-email-mano@roarinelk.homelinux.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.9.9
Le Friday 22 May 2009 22:24:59 Manuel Lauss, vous avez écrit :
> Remove a few GPIO register accesses in the board init code with calls
> to the gpio api.
>
> Signed-off-by: Manuel Lauss <mano@roarinelk.homelinux.net>

Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
>  arch/mips/alchemy/xxs1500/board_setup.c |   18 ++++++++++--------
>  1 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/arch/mips/alchemy/xxs1500/board_setup.c
> b/arch/mips/alchemy/xxs1500/board_setup.c index a2634fa..ed7d999 100644
> --- a/arch/mips/alchemy/xxs1500/board_setup.c
> +++ b/arch/mips/alchemy/xxs1500/board_setup.c
> @@ -23,6 +23,7 @@
>   *  675 Mass Ave, Cambridge, MA 02139, USA.
>   */
>
> +#include <linux/gpio.h>
>  #include <linux/init.h>
>  #include <linux/delay.h>
>
> @@ -65,20 +66,21 @@ void __init board_setup(void)
>       au_writel(0x01, UART3_ADDR + UART_MCR); /* UART_MCR_DTR is 0x01??? */
>
>  #ifdef CONFIG_PCMCIA_XXS1500
> -     /* Setup PCMCIA signals */
> -     au_writel(0, SYS_PININPUTEN);
> +     alchemy_gpio2_enable();
>
>       /* GPIO 0, 1, and 4 are inputs */
> -     au_writel(1 | (1 << 1) | (1 << 4), SYS_TRIOUTCLR);
> +     alchemy_gpio_direction_input(0);
> +     alchemy_gpio_direction_input(1);
> +     alchemy_gpio_direction_input(4);
>
> -     /* Enable GPIO2 if not already enabled */
> -     au_writel(1, GPIO2_ENABLE);
>       /* GPIO2 208/9/10/11 are inputs */
> -     au_writel((1 << 8) | (1 << 9) | (1 << 10) | (1 << 11), GPIO2_DIR);
> +     alchemy_gpio_direction_input(208);
> +     alchemy_gpio_direction_input(209);
> +     alchemy_gpio_direction_input(210);
> +     alchemy_gpio_direction_input(211);
>
>       /* Turn off power */
> -     au_writel((au_readl(GPIO2_PINSTATE) & ~(1 << 14)) | (1 << 30),
> -               GPIO2_OUTPUT);
> +     alchemy_gpio_direction_output(214, 0);
>  #endif
>
>  #ifdef CONFIG_PCI



-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------

<Prev in Thread] Current Thread [Next in Thread>