linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] rb532: check irq number when handling GPIO interrupts

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 2/2] rb532: check irq number when handling GPIO interrupts
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 22 May 2009 07:57:26 +0100
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-mips@linux-mips.org
In-reply-to: <200905220703.28939.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200905211949.47486.florian@openwrt.org> <4A15A2DD.2000203@ru.mvista.com> <200905220703.28939.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, May 22, 2009 at 07:03:28AM +0200, Florian Fainelli wrote:

> That's actually 14, numbering starting from 0, I should learn how to count. 
> Ralf, do you want me to resubmit that one with the proper message / 
> descriptions ?
> 
> >
> > >                   rb532_gpio_set_istat(0, irq_nr - GPIO_MAPPED_IRQ_BASE);
> > >
> > >           /*
> > > @@ -174,7 +175,7 @@ static int rb532_set_type(unsigned int irq_nr,
> > > unsigned type) int gpio = irq_nr - GPIO_MAPPED_IRQ_BASE;
> > >   int group = irq_to_group(irq_nr);
> > >
> > > - if (group != GPIO_MAPPED_IRQ_GROUP)
> > > + if (group != GPIO_MAPPED_IRQ_GROUP || irq_nr > (GROUP4_IRQ_BASE + 13))
> >
> >     ... and >= here.
> >
> > >           return (type == IRQ_TYPE_LEVEL_HIGH) ? 0 : -EINVAL;
> > >
> > >   switch (type) {

Queued for 2.6.31 with the comment fix and the change from > to >=.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>