[Top] [All Lists]

Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of

To: David Daney <>
Subject: Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of pci_fixup_irqs
From: Ralf Baechle <>
Date: Thu, 21 May 2009 09:13:54 +0100
Cc:,, Yan hua <>, Philippe Vachon <>, Zhang Le <>, Zhang Fuxin <>, Arnaud Patard <>,,, Nicholas Mc Guire <>, Liu Junliang <>, Erwan Lerale <>
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, May 20, 2009 at 03:11:08PM -0700, David Daney wrote:

> This is the correct fix, however there are now Cavium Octeon PCI drivers  
> on Ralf's queue.

The reason for the const is that people keep doing very broken things in
pcibios_map_irq().  I don't see any legitimate reason why pcibios_map_irq
should modifiy the structure the first argument is pointing to, so I
changed it to const just to be a pain in the arse.  Of course the warning
should be rectified but this requires talking to the upstream PCI guys.


<Prev in Thread] Current Thread [Next in Thread>