Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of

To:	David Daney <ddaney@caviumnetworks.com>
Subject:	Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of pci_fixup_irqs
From:	Ralf Baechle <ralf@linux-mips.org>
Date:	Thu, 21 May 2009 09:13:54 +0100
Cc:	wuzhangjin@gmail.com, linux-mips@linux-mips.org, Yan hua <yanh@lemote.com>, Philippe Vachon <philippe@cowpig.ca>, Zhang Le <r0bertz@gentoo.org>, Zhang Fuxin <zhangfx@lemote.com>, Arnaud Patard <apatard@mandriva.com>, loongson-dev@googlegroups.com, gnewsense-dev@nongnu.org, Nicholas Mc Guire <hofrat@hofr.at>, Liu Junliang <liujl@lemote.com>, Erwan Lerale <erwan@thiscow.com>
In-reply-to:	<4A147FFC.5070608@caviumnetworks.com>
Original-recipient:	rfc822;linux-mips@linux-mips.org
References:	<cover.1242855716.git.wuzhangjin@gmail.com> <f3a0b5ce4e2e228576f4481f4dfff8d75d33db7a.1242855716.git.wuzhangjin@gmail.com> <4A147FFC.5070608@caviumnetworks.com>
Sender:	linux-mips-bounce@linux-mips.org
User-agent:	Mutt/1.5.18 (2008-05-17)

On Wed, May 20, 2009 at 03:11:08PM -0700, David Daney wrote:

> This is the correct fix, however there are now Cavium Octeon PCI drivers  
> on Ralf's queue.

The reason for the const is that people keep doing very broken things in
pcibios_map_irq().  I don't see any legitimate reason why pcibios_map_irq
should modifiy the structure the first argument is pointing to, so I
changed it to const just to be a pain in the arse.  Of course the warning
should be rectified but this requires talking to the upstream PCI guys.

  Ralf

<Prev in Thread]	Current Thread	[Next in Thread>
[loongson-PATCH-v1 00/27] linux patches of loongson-based machines, wuzhangjin [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of pci_fixup_irqs, wuzhangjin Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of pci_fixup_irqs, David Daney Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of pci_fixup_irqs, Wu Zhangjin Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of pci_fixup_irqs, Ralf Baechle <= [loongson-PATCH-v1 02/27] fix-warning: incompatible argument type of virt_to_phys, wuzhangjin Re: [loongson-PATCH-v1 02/27] fix-warning: incompatible argument type of virt_to_phys, Ralf Baechle [loongson-PATCH-v1 03/27] fix-error: incompatiable argument type of clear_user, wuzhangjin Re: [loongson-PATCH-v1 03/27] fix-error: incompatiable argument type of clear_user, Ralf Baechle [loongson-PATCH-v1 04/27] change the naming methods, wuzhangjin [loongson-PATCH-v1 05/27] remove reference to bonito64.h, wuzhangjin [loongson-PATCH-v1 06/27] divide the files to the smallest logic unit, wuzhangjin [loongson-PATCH-v1 07/27] replace tons of magic numbers by understandable symbols, wuzhangjin [loongson-PATCH-v1 08/27] clean up the early printk support for fuloong(2e), wuzhangjin [loongson-PATCH-v1 09/27] enable Real Time Clock Support for fuloong(2e), wuzhangjin

Previous by Date:	Re: [loongson-PATCH-v1 02/27] fix-warning: incompatible argument type of virt_to_phys, Ralf Baechle
Next by Date:	Re: [PATCH] fix gpio_direction_output for bcm47xx, Aurelien Jarno
Previous by Thread:	Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of pci_fixup_irqs, Wu Zhangjin
Next by Thread:	[loongson-PATCH-v1 02/27] fix-warning: incompatible argument type of virt_to_phys, wuzhangjin
Indexes:	[Date] [Thread] [Top] [All Lists]