linux-mips
[Top] [All Lists]

Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [loongson-PATCH-v1 01/27] fix-warning: incompatible argument type of pci_fixup_irqs
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 21 May 2009 09:13:54 +0100
Cc: wuzhangjin@gmail.com, linux-mips@linux-mips.org, Yan hua <yanh@lemote.com>, Philippe Vachon <philippe@cowpig.ca>, Zhang Le <r0bertz@gentoo.org>, Zhang Fuxin <zhangfx@lemote.com>, Arnaud Patard <apatard@mandriva.com>, loongson-dev@googlegroups.com, gnewsense-dev@nongnu.org, Nicholas Mc Guire <hofrat@hofr.at>, Liu Junliang <liujl@lemote.com>, Erwan Lerale <erwan@thiscow.com>
In-reply-to: <4A147FFC.5070608@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1242855716.git.wuzhangjin@gmail.com> <f3a0b5ce4e2e228576f4481f4dfff8d75d33db7a.1242855716.git.wuzhangjin@gmail.com> <4A147FFC.5070608@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, May 20, 2009 at 03:11:08PM -0700, David Daney wrote:

> This is the correct fix, however there are now Cavium Octeon PCI drivers  
> on Ralf's queue.

The reason for the const is that people keep doing very broken things in
pcibios_map_irq().  I don't see any legitimate reason why pcibios_map_irq
should modifiy the structure the first argument is pointing to, so I
changed it to const just to be a pain in the arse.  Of course the warning
should be rectified but this requires talking to the upstream PCI guys.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>