linux-mips
[Top] [All Lists]

Re: [loongson-PATCH-v1 03/27] fix-error: incompatiable argument type of

To: wuzhangjin@gmail.com
Subject: Re: [loongson-PATCH-v1 03/27] fix-error: incompatiable argument type of clear_user
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 21 May 2009 08:51:04 +0100
Cc: linux-mips@linux-mips.org, Yan hua <yanh@lemote.com>, Philippe Vachon <philippe@cowpig.ca>, Zhang Le <r0bertz@gentoo.org>, Zhang Fuxin <zhangfx@lemote.com>, Arnaud Patard <apatard@mandriva.com>, loongson-dev@googlegroups.com, gnewsense-dev@nongnu.org, Nicholas Mc Guire <hofrat@hofr.at>, Liu Junliang <liujl@lemote.com>, Erwan Lerale <erwan@thiscow.com>
In-reply-to: <8f44bd7169af8d4fdafa42ce4750943ef4da439f.1242855716.git.wuzhangjin@gmail.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1242855716.git.wuzhangjin@gmail.com> <8f44bd7169af8d4fdafa42ce4750943ef4da439f.1242855716.git.wuzhangjin@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, May 21, 2009 at 05:50:01AM +0800, wuzhangjin@gmail.com wrote:

> From: Wu Zhangjin <wuzhangjin@gmail.com>
> 
> there are lots of warnings about the macro: clear_user in linux-mips.
> 
> the type of the second argument of access_ok should be (void __user *),
> but there is an un-needed (unsigned long) conversion before __cl_addr,
> so, remove the (unsigned long) will fix this problem.

I assume you're talking about sparse warnings, not gcc warnings?

Either way, access_ok() is defined to take pointer arguments, so patch
applied.  Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>