linux-mips
[Top] [All Lists]

Re: [PATCH 23/30] loongson: CS5536 MFGPT as system clock source support

To: john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH 23/30] loongson: CS5536 MFGPT as system clock source support
From: Wu Zhangjin <wuzhangjin@gmail.com>
Date: Sat, 16 May 2009 09:15:41 +0800
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, linux-kernel@vger.kernel.org, Arnaud Patard <apatard@mandriva.com>, loongson-dev@googlegroups.com, zhangfx@lemote.com, yanh@lemote.com, Philippe Vachon <philippe@cowpig.ca>, Zhang Le <r0bertz@gentoo.org>, Erwan Lerale <erwan@thiscow.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:reply-to:to:cc :in-reply-to:references:content-type:organization:date:message-id :mime-version:x-mailer:content-transfer-encoding; bh=lPbdgSe1NScph2HA71NztWlaO9idDejtwn/Mo684+04=; b=tPb5X6fQnijHqHlMIEyq8kyRVD4WcN2C8t4A7Ou2RIZ6jniXadU7JyNb7xDKa0S983 0NedBPOArM+TIMbEqKaaltvgO1A4uiXUmm9l7EmjTxp6iJKiNcS4Bkljl6KdJJuRlMm3 rA6MrOY93cG9jGgXmX4ZXRVkBHDry6Mx5sxxo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:in-reply-to:references:content-type :organization:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=wTJd861BVXwqf0wl9DT5VreohgHHqxAe/FPuc7QvMh+ooIJrX/tzJW61u4WrhrtD62 fFF9qIgRnJEDZVmip1hfhtkfM9mafEEvAipul+lM++K2vzwkNrjuh34/d5V0xO3xhmBf PLvfYOnEsRCTF0yshhMmxCMRfJYqaoeIVkb9c=
In-reply-to: <1f1b08da0905151739v6bc2e5f6t57cb8e06cdda2673@mail.gmail.com>
Organization: DSLab, Lanzhou University, China
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1242426182.10164.168.camel@falcon> <1f1b08da0905151739v6bc2e5f6t57cb8e06cdda2673@mail.gmail.com>
Reply-to: wuzhangjin@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Fri, 2009-05-15 at 17:39 -0700, john stultz wrote:
> On Fri, May 15, 2009 at 3:23 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> > +static struct clocksource clocksource_mfgpt = {
> > +    .name = "mfgpt",
> > +    .rating = 1200,
> 
> Minor nit. Please read the comment over the struct clocksource
> definition in include/linux/clocksource.h for a guide to setting the
> rating value for your clocksource.
> 

as the comment describes, just like the 8253 Timer, the precision of
cs5536 mfgpt Timer is not good, the rating of it should be in the range
of 100-199? Functional for real use, but not desired?

thanks!
Wu Zhangjin


<Prev in Thread] Current Thread [Next in Thread>