linux-mips
[Top] [All Lists]

Re: [PATCH 23/30] loongson: CS5536 MFGPT as system clock source support

To: wuzhangjin@gmail.com
Subject: Re: [PATCH 23/30] loongson: CS5536 MFGPT as system clock source support
From: john stultz <johnstul@us.ibm.com>
Date: Fri, 15 May 2009 17:39:43 -0700
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, linux-kernel@vger.kernel.org, Arnaud Patard <apatard@mandriva.com>, loongson-dev@googlegroups.com, zhangfx@lemote.com, yanh@lemote.com, Philippe Vachon <philippe@cowpig.ca>, Zhang Le <r0bertz@gentoo.org>, Erwan Lerale <erwan@thiscow.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=/hcIxAFUd7coO4N13EL2e5zXG5j+D0sKtLtqbu4gS6c=; b=km2ryQ6NieBjf7sLanvv+pfuPaPCLe+nLoUBtSTyJJUvc6dQee39UMtOKJMOssxoc8 mdDjXx6hSYAa7u70SgA36bT06YFz5yaVfGuq2WshRyh8vjxoWlywRmETNk7PNW2Gt4En 2DbN3Tzmq/mL0ywOTUsWuIlwz4V/517lPJ4yY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=UuNShpY6o9Eox2jKk5YXl5Lr0qE0QbEDVOOyCchfF/m9hFx7d19bJRuhsQHRJ0r4De L+oKZPEENt6zUcWKlcp0xULjy/kzbWupOl2MmAmwAqfUckq3lPY8PmAS6Gm/IhwneSZf P2jkVyzueWQD32G4Pt60pqdYo820EtJlzlpMY=
In-reply-to: <1242426182.10164.168.camel@falcon>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1242426182.10164.168.camel@falcon>
Sender: linux-mips-bounce@linux-mips.org
On Fri, May 15, 2009 at 3:23 PM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> +static struct clocksource clocksource_mfgpt = {
> +       .name = "mfgpt",
> +       .rating = 1200,

Minor nit. Please read the comment over the struct clocksource
definition in include/linux/clocksource.h for a guide to setting the
rating value for your clocksource.

thanks
-john

<Prev in Thread] Current Thread [Next in Thread>