| To: | David Daney <ddaney@caviumnetworks.com> |
|---|---|
| Subject: | Re: [PATCH 2/2] MIPS: Replace some magic numbers with symbolic values in tlbex.c (v2) |
| From: | David Daney <ddaney@caviumnetworks.com> |
| Date: | Wed, 13 May 2009 15:17:55 -0700 |
| Cc: | linux-mips@linux-mips.org, ralf@linux-mips.org, paul.gortmaker@windriver.com, David VomLehn <dvomlehn@cisco.com> |
| In-reply-to: | <1242252913-6581-1-git-send-email-ddaney@caviumnetworks.com> |
| Original-recipient: | rfc822;linux-mips@linux-mips.org |
| References: | <1242247717-21324-2-git-send-email-ddaney@caviumnetworks.com> <1242252913-6581-1-git-send-email-ddaney@caviumnetworks.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Well I replied to the wrong message and screwed up the subject. So Ignore this one and I will send it again properly David Daney David Daney wrote: The logic used to split the r4000 refill handler is liberally sprinkled with magic numbers. We attempt to explain what they are and normalize them against a new symbolic value (MIPS64_REFILL_INSNS). Changes from v1: Corrected spelling in comment. CC: David VomLehn <dvomlehn@cisco.com> Reviewed-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David Daney <ddaney@caviumnetworks.com> --- Please use this version instead of the original 2/2. arch/mips/mm/tlbex.c | 34 ++++++++++++++++++++++++++-------- 1 files changed, 26 insertions(+), 8 deletions(-) diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c index 4dc4f3e..cbc09de 100644 --- a/arch/mips/mm/tlbex.c +++ b/arch/mips/mm/tlbex.c @@ -649,6 +649,14 @@ static void __cpuinit build_update_entries(u32 **p, unsigned int tmp, #endif |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/2] MIPS: Replace some magic numbers with symbolic values in tlbex.c (v2), David Daney |
|---|---|
| Next by Date: | [PATCH 1/2] MIPS: Replace some magic numbers with symbolic values in tlbex.c (v2), David Daney |
| Previous by Thread: | [PATCH 2/2] MIPS: Replace some magic numbers with symbolic values in tlbex.c (v2), David Daney |
| Next by Thread: | [PATCH 1/2] MIPS: Replace some magic numbers with symbolic values in tlbex.c, David Daney |
| Indexes: | [Date] [Thread] [Top] [All Lists] |