linux-mips
[Top] [All Lists]

Re: [PATCH 3/3] MIPS: Remove dead case label.

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 3/3] MIPS: Remove dead case label.
From: David VomLehn <dvomlehn@cisco.com>
Date: Tue, 12 May 2009 15:41:43 -0700
Authentication-results: sj-dkim-3; header.From=dvomlehn@cisco.com; dkim=pass ( sig from cisco.com/sjdkim3002 verified; );
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; q=dns/txt; l=867; t=1242168103; x=1243032103; c=relaxed/simple; s=sjdkim3002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=dvomlehn@cisco.com; z=From:=20David=20VomLehn=20<dvomlehn@cisco.com> |Subject:=20Re=3A=20[PATCH=203/3]=20MIPS=3A=20Remove=20dead =20case=20label. |Sender:=20; bh=RPiJupRzI2gIuT+r05ABMdM5D9pZozK8qmODqLoLYqQ=; b=uLcTC/qZZUru/yJO28AYyFmKcG8Qudo6GU3IsmAhkw50F65kbVjFk7H3AQ v94D5tQEOk8iX6m0YBgq2RWMOTAK3lNYS2/FpL6SPt66MC8FgHbRjKl2aStR /JGxhqkQb5;
In-reply-to: <1242157315-20719-3-git-send-email-ddaney@caviumnetworks.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <4A09D0B1.2030305@caviumnetworks.com> <1242157315-20719-3-git-send-email-ddaney@caviumnetworks.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, May 12, 2009 at 12:41:55PM -0700, David Daney wrote:
> CPU_CAVIUM_OCTEON is mips_r2 which is handled before the switch.  This
> label in the switch statement is dead code, so we remove it.
> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>
> ---
>  arch/mips/mm/tlbex.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 4108674..4dc4f3e 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -311,7 +311,6 @@ static void __cpuinit build_tlb_write_entry(u32 **p, 
> struct uasm_label **l,
>       case CPU_BCM3302:
>       case CPU_BCM4710:
>       case CPU_LOONGSON2:
> -     case CPU_CAVIUM_OCTEON:
>       case CPU_R5500:
>               if (m4kc_tlbp_war())
>                       uasm_i_nop(p);

Fewer lines of code is good...

Reviewed by: David VomLehn <dvomlehn@cisco.com>

<Prev in Thread] Current Thread [Next in Thread>