Re: [PATCH 2/3] mips:powertv: Make kernel command line size configurable (resend)

[David VomLehn <dvomlehn@cisco.com>]

On Fri, May 08, 2009 at 11:25:35AM -0400, Paul Gortmaker wrote:
> On Mon, May 4, 2009 at 6:57 PM, David VomLehn <dvomlehn@cisco.com> wrote:
> > Most platforms can get by perfectly well with the default command line size,
> > but some platforms need more. This patch allows the command line size to
> > be configured for those platforms that need it. The default remains 256
> > characters.
> 
> The one thing I see when I look at this patch, is that it lands in the
> arch/mips/Kconfig -- but is there really anything fundamentally
> architecture specific about the allowed length of the kernel command
> line?.  It probably belongs somewhere alongside the setting for
> LOG_BUF_LEN or similar (and then add the other respective changes
> to make all arch actually respect the setting.)
> 
> Paul.
> 
> >
> > Signed-off-by: David VomLehn <dvomlehn@cisco.com>
> > ---
> >  arch/mips/Kconfig             |    7 +++++++
> >  arch/mips/include/asm/setup.h |    2 +-

The reason I put this configuration configuration in the architecture-
specific Kconfig is because COMMAND_LINE_SIZE is defined in the
architecture-specific file arch/mips/include/asm/setup.h. I strongly
agree that this really should not be an architecture-specific definition,
but it's much more complex to get a patch to change COMMAND_LINE_SIZE
in every architecture. Fixing in the MIPS tree seems like a good
start.

David VomLehn