linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] mips:powertv: Make kernel command line size configurabl

To: David VomLehn <dvomlehn@cisco.com>
Subject: Re: [PATCH 2/3] mips:powertv: Make kernel command line size configurable (resend)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Fri, 8 May 2009 11:25:35 -0400
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=z6TKZXLUyq4/TiNJZ2FAR/LbDB6fBlnyY9zUj0CULFA=; b=b2SdgFiWabKwMAHwMiJ5PHXZtE01n07drWNW6EoMcX/1AYOhFBgFOCV8X1N2IsIxf9 b1SE6k7dre0Ra26pdtZud1hehliEpK/vKIR6VC1HQpN0CnVDi9xErpxnKZTPGcQ7Mz8q HmUmc4oAa0LPf+0177DNwchnRP4eIBqmMZghA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=iCotSVbxQS1L9nDEFlFze6v0QTv4ALBwHZCjw3s0BN5yIINnasW9jzYcWQp9sqSDRr oXX3lRMM6vwLvh1zOZSlh+zCOBqSLRu4L+6ZZfRYdWC6ziZPoCi8mpiMBcpqD0daqBL+ NDea65HgzZo7uJaWVswtMaibLUZQDhsLj8tYI=
In-reply-to: <20090504225719.GA22417@cuplxvomd02.corp.sa.net>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20090504225719.GA22417@cuplxvomd02.corp.sa.net>
Sender: linux-mips-bounce@linux-mips.org
On Mon, May 4, 2009 at 6:57 PM, David VomLehn <dvomlehn@cisco.com> wrote:
> Most platforms can get by perfectly well with the default command line size,
> but some platforms need more. This patch allows the command line size to
> be configured for those platforms that need it. The default remains 256
> characters.

The one thing I see when I look at this patch, is that it lands in the
arch/mips/Kconfig -- but is there really anything fundamentally
architecture specific about the allowed length of the kernel command
line?.  It probably belongs somewhere alongside the setting for
LOG_BUF_LEN or similar (and then add the other respective changes
to make all arch actually respect the setting.)

Paul.

>
> Signed-off-by: David VomLehn <dvomlehn@cisco.com>
> ---
>  arch/mips/Kconfig             |    7 +++++++
>  arch/mips/include/asm/setup.h |    2 +-
>  2 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 998e5db..99f7b6d 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -780,6 +780,13 @@ config EARLY_PRINTK
>  config SYS_HAS_EARLY_PRINTK
>        bool
>
> +config COMMAND_LINE_SIZE
> +       int "Maximum size of command line passed to kernel from bootloader"
> +       default 256
> +       help
> +         Most systems work well with the default value, but some bootloaders 
> pass more
> +         information on the command line than others. A smaller value is 
> good here.
> +
>  config HOTPLUG_CPU
>        bool
>        default n
> diff --git a/arch/mips/include/asm/setup.h b/arch/mips/include/asm/setup.h
> index e600ced..132e397 100644
> --- a/arch/mips/include/asm/setup.h
> +++ b/arch/mips/include/asm/setup.h
> @@ -1,7 +1,7 @@
>  #ifndef _MIPS_SETUP_H
>  #define _MIPS_SETUP_H
>
> -#define COMMAND_LINE_SIZE      256
> +#define COMMAND_LINE_SIZE      CONFIG_COMMAND_LINE_SIZE
>
>  #ifdef  __KERNEL__
>  extern void setup_early_printk(void);
>
>

<Prev in Thread] Current Thread [Next in Thread>