linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] mips:powertv: Make kernel command line size configurable

To: jfraser@broadcom.com
Subject: Re: [PATCH 2/3] mips:powertv: Make kernel command line size configurable (resend)
From: David Daney <ddaney@caviumnetworks.com>
Date: Wed, 06 May 2009 11:29:13 -0700
Cc: David VomLehn <dvomlehn@cisco.com>, Ralf Baechle <ralf@linux-mips.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
In-reply-to: <1241634456.10498.11.camel@chaos.ne.broadcom.com>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20090504225719.GA22417@cuplxvomd02.corp.sa.net> <20090506163518.GA19624@linux-mips.org> <20090506181931.GA14025@cuplxvomd02.corp.sa.net> <4A01D5C7.4090900@caviumnetworks.com> <1241634456.10498.11.camel@chaos.ne.broadcom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Jon Fraser wrote:

On Wed, 2009-05-06 at 11:24 -0700, David Daney wrote:
David VomLehn wrote:
On Wed, May 06, 2009 at 05:35:18PM +0100, Ralf Baechle wrote:
On Mon, May 04, 2009 at 03:57:19PM -0700, David VomLehn wrote:

Most platforms can get by perfectly well with the default command line size,
but some platforms need more. This patch allows the command line size to
be configured for those platforms that need it. The default remains 256
characters.

Signed-off-by: David VomLehn <dvomlehn@cisco.com>
How big of a command line do you need?  For no scientific reason other
than there not being any obvious need for a larger size MIPS is using 256
and I think unless you're asking for a huge number it will be better to
just raise that constant.
The answer depends on the platform, but it's at 438 characters on a typical
platform. If I *had* to pick a number, I'd probably go for 512 characters; I
just hate to force others to use memory they aren't going to use.

I wonder if the memory could be dynamically allocated. It would of course be a much larger patch.

David Daney




A bit of a chicken and egg problem if your command line arguments
set the memory configuration.


I was thinking of putting it in __initdata memory, and then copying it to dynamically allocated memory before freeing the init memory.

David Daney

<Prev in Thread] Current Thread [Next in Thread>