linux-mips
[Top] [All Lists]

Re: [PATCH] fix build failures on msp_irq_slp.c

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] fix build failures on msp_irq_slp.c
From: Shane McDonald <mcdonald.shane@gmail.com>
Date: Wed, 29 Apr 2009 08:18:11 -0600
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=4fWGn8xZqXhse1COeKCcp1fw65io+mImTLPnYjPJJfQ=; b=ZxSPqXnTLwC4cNQpZ7Njw6UXDON/mWpM/uwAfhypHh71V5jXqp4jTwDkrKFJdUlkd5 IE7vVVlx9rWpUlzu0N4j634a5ESuRP8X87Yvc4P4Owwu+pW5QauLC+yJUfa7aqBv1rs5 zewkM7OBT5YVq8KqSzAV8TN0HkCHIzOunW4j8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=YLomPYO6Q5zjUIfhLlOkGBjJ0GW0fQOneVAaEsL7zIUOaQj195NEDjXzFJ/Nuga/su JYLNTBaOwmI7qdugjJ4W6UjbOjrJCChP6zvd3yz1mwPjPH10+dd/IJWla35nlzjYmob+ KKlmku5EM6Yh2fbrBqREiCExUoJHa59qJwlSI=
In-reply-to: <200904291512.19297.florian@openwrt.org>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <200904271659.48357.florian@openwrt.org> <20090429115859.GA1487@linux-mips.org> <200904291512.19297.florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
Hello:

On Wed, Apr 29, 2009 at 7:12 AM, Florian Fainelli <florian@openwrt.org> wrote:
Hi Ralf, Shane,

Le Wednesday 29 April 2009 13:58:59 Ralf Baechle, vous avez écrit :
> The whole irq chip thing in this file is looking suspect as it treats
> acknowledging and mask an interrupt as the same thing.  Sure that is the
> right thing?
That is a quick and dirty fix which compiles, I assumed that the function
meant to be called is mask_msp_slp_irq, Shane probably knows more about how
this should be fixed.
 
It's been quite a while since I messed around with the 4200.  I'll do some digging and ask some questions of guys who probably know better.
 
Shane
<Prev in Thread] Current Thread [Next in Thread>